[
https://issues.apache.org/jira/browse/ROL-2020?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Glen Mazza closed ROL-2020.
---------------------------
Resolution: Not a Problem
Hi Gaurav, I made a mistake on this issue, I wasn't thinking at all about CDNs
when I typed it up. While we do embed some JS / CSS files like JQuery and YUI
in the roller-ui folder, that's primarily because our UI needs them, and we'd
like to keep our UI standalone (not need CDNs), see
http://markmail.org/message/7k5rmeckfadj2yr7.
There's a nice gain however to having the themes use CDNs, namely less server
bandwidth consumed, making Roller cheaper to host. So I think that should
remain the default solution if someone wants to create a new theme without
needing to include the bootstrap/jquery files. Another problem with us
"hosting" boostrap within our roller-ui is that it might be difficult for us to
upgrade that library w/new Roller releases without breaking backwards
compatibility for custom blogs referencing that library.
Whether you wish to modify the gaurav theme to use CDNs out of the box, or
continue using its embedded theme, that's up to you -- there's advantages and
disadvantages to both, I don't have a strong opinion on that.
> Make the Bootstrap Library available for all themes.
> ----------------------------------------------------
>
> Key: ROL-2020
> URL: https://issues.apache.org/jira/browse/ROL-2020
> Project: Apache Roller
> Issue Type: Task
> Reporter: Glen Mazza
> Assignee: Roller Unassigned
>
> The gaurav theme incorporates the Bootstrap library. Just so every
> Bootstrap-needing theme doesn't have to include its own Bootstrap library,
> factor out Bootstrap into webapp/roller-ui and have the gaurav theme
> reference it from there, similar to as done presently with
> webapp/roller-ui/yui and fauxcoly.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
