[
https://issues.apache.org/jira/browse/ROL-2095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15054377#comment-15054377
]
David Johnson commented on ROL-2095:
------------------------------------
Yes, in MySQL Roller used Timestamp instead of DateTime and I can't really
remember why (might be because of my lack of advanced Hibernate or JPA skills
;-) DateTime is definitely better. Timestamp fields automatically update when
you update the record that contains them, which is annoying and has been a
source of bugs in Roller over the years.
I have some ideas about how to migrate the timestamp fields and I hope to try
them out this weekend. I will also try that useFastDateParsing trick that you
mentioned.
> Roller 510 -> 520 migration is incomplete for TIMESTAMPS
> --------------------------------------------------------
>
> Key: ROL-2095
> URL: https://issues.apache.org/jira/browse/ROL-2095
> Project: Apache Roller
> Issue Type: Bug
> Reporter: David Johnson
> Assignee: Roller Unassigned
>
> In SVN commit 1680531 we added to mysql.properties these two lines:
> TIMESTAMP_SQL_TYPE_NULL=datetime(3) NULL
> TIMESTAMP_SQL_TYPE=datetime(3)
> Those lines effectively changed the type of all timestamp columns in Roller
> from timestamp to datetime(3), but we offer no migration to convert timestamp
> data to datatime(3) format.
> This will cause Roller to fail to work with errors like this:
> [EL Warning]: 2015-12-06 16:09:42.61--UnitOfWork(659709738)--Exception
> [EclipseLink-4002] (Eclipse Persistence Services - 2.5.2.v20140319-9ad6abd):
> org.eclipse.persistence.exceptions.DatabaseException
> Internal Exception: java.sql.SQLException: Cannot convert value '2014-11-27
> 10:25:01.000' from column 8 to TIMESTAMP.
> Error Code: 0
> Call: SELECT id, about, isactive, allowcomments, analyticscode, blacklist,
> creator, datecreated, defaultallowcomments, defaultcommentdays,
> defaultplugins, editorpage, editortheme, emailaddress, emailcomments,
> enablebloggerapi, enablemultilang, displaycnt, handle, icon, lastmodified,
> locale, commentmod, name, showalllangs, tagline, timeZone, visible,
> bloggercatid FROM weblog WHERE (handle = ?)
> bind => [1 parameter bound]
> Query: ReadAllQuery(name="Weblog.getByHandle" referenceClass=Weblog
> sql="SELECT id, about, isactive, allowcomments, analyticscode, blacklist,
> creator, datecreated, defaultallowcomments, defaultcommentdays,
> defaultplugins, editorpage, editortheme, emailaddress, emailcomments,
> enablebloggerapi, enablemultilang, displaycnt, handle, icon, lastmodified,
> locale, commentmod, name, showalllangs, tagline, timeZone, visible,
> bloggercatid FROM weblog WHERE (handle = ?)")
> We should either revert the datetime(3) change or add a migration for all
> fields effected.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
