[
https://issues.apache.org/jira/browse/ROL-2101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15599263#comment-15599263
]
ASF GitHub Bot commented on ROL-2101:
-------------------------------------
Github user asfgit closed the pull request at:
https://github.com/apache/roller/pull/5
> Thread unsafe use of HashMap for cached mappings exist
> ------------------------------------------------------
>
> Key: ROL-2101
> URL: https://issues.apache.org/jira/browse/ROL-2101
> Project: Apache Roller
> Issue Type: Bug
> Components: Data Model & JPA Backend
> Affects Versions: 5.1.2
> Reporter: Kohei Nozaki
> Assignee: Roller Unassigned
> Priority: Minor
> Attachments: ROL-2101.patch
>
>
> There are two singleton classes that have a instance field type of
> {{HashMap}} for cache.
> In {{JPAUserManagerImpl}}:
> {noformat}
> // cached mapping of userNames -> userIds
> private Map<String, String> userNameToIdMap = new HashMap<String, String>();
> {noformat}
> In {{JPAWeblogEntryManagerImpl}}:
> {noformat}
> // cached mapping of entryAnchors -> entryIds
> private Map<String, String> entryAnchorToIdMap = new HashMap<String,
> String>();
> {noformat}
> {{HashMap}} s should not be used as the above because it's not thread safe.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
