[ 
https://issues.apache.org/jira/browse/ROL-2108?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15737442#comment-15737442
 ] 

Kohei Nozaki commented on ROL-2108:
-----------------------------------

By the way, is it ok to use try-with-resources syntax?

I can see that maven-compiler-plugin in pom.xml configured as source / target 
to 1.7, so that should be ok but I can't see any use of the syntax in current 
Roller code.

> Close unclosed FileInputStreams explicitly
> ------------------------------------------
>
>                 Key: ROL-2108
>                 URL: https://issues.apache.org/jira/browse/ROL-2108
>             Project: Apache Roller
>          Issue Type: Bug
>    Affects Versions: 5.1.2
>            Reporter: Kohei Nozaki
>            Assignee: Roller Unassigned
>            Priority: Trivial
>
> Apparently there are some unclosed FileInputStreams in Roller code. Those 
> unclosed ones may be closed by FileInputStream#finalize implicitly, but I 
> think those should be closed explicitly. One example:
> https://github.com/lbtc-xxx/roller/commit/d99de256a95bea97445551ecec621a083462312f



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to