[
https://issues.apache.org/jira/browse/ROL-2184?focusedWorklogId=1045601&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-1045601
]
ASF GitHub Bot logged work on ROL-2184:
---------------------------------------
Author: ASF GitHub Bot
Created on: 04/Oct/26 17:39
Start Date: 04/Oct/26 17:39
Worklog Time Spent: 10m
Work Description: snoopdave commented on PR #205:
URL: https://github.com/apache/roller/pull/205#issuecomment-5982668830
Manually tested at c7a34f114 on the 6.1.7 integration build (Tomcat 9, JDK
11, MySQL 8). Pass.
- **Upload path:** pasted and dragged images become media files. The same
image pasted twice is uploaded once. Images in the summary work too.
- **Inline path:**
- A Limited member, `preferInline`, and uploads disabled all keep images
inline.
- Inline images display in every bundled theme, with no CSP errors.
- The 60,000-byte limit is enforced. 250000 works after changing the
columns to `MEDIUMTEXT`.
- **Refused:** SVG data, mismatched image types, and images over the upload
limit. `<embed data:>` is stripped when rendered.
Testing added these fixes:
- 4aa233541: an inline image over the limit is reported as too large, not
invalid.
- adeb6fc9b, 03911f900, 7333029bc: a POST over Tomcat's `maxPostSize` gets a
"Form too large" 413 page instead of a 500. `maxPostSize` is documented.
- c7a34f114: the apostrophe in the upload-limit message.
Issue Time Tracking
-------------------
Worklog Id: (was: 1045601)
Time Spent: 1h 20m (was: 1h 10m)
> Pasted desktop images disappear from published entries
> ------------------------------------------------------
>
> Key: ROL-2184
> URL: https://issues.apache.org/jira/browse/ROL-2184
> Project: Apache Roller
> Issue Type: Bug
> Components: Media files / uploads, Themes and Macros, User Interface
> - Weblog Editor
> Reporter: David M. Johnson
> Assignee: David M. Johnson
> Priority: Major
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> Reported against 6.1.6.
> If you drag a desktop image into the rich text editor, it becomes a {{data:}}
> image. It shows while you edit, but the published entry leaves it out:
> rendering strips {{data:}} images, and the bundled themes' CSP blocks them.
> Fix both paths:
> # *Upload (preferred).* When upload is available, upload new pasted or
> dropped images as media files. Convert stored inline images the next time an
> entry is saved. Leave remote images unchanged. Use Roller's existing checks
> for upload permission, file type, size and quota.
> # *Inline fallback.* When upload is unavailable, or when the new global
> "inline images" preference is set, store the image inline. Accept only
> strictly validated PNG, JPEG and GIF data images, with a 60,000-byte field
> limit.
> h3. Acceptance
> * New pastes and drops, and edits of old entries, produce working published
> images on both paths. Check the draft and publish flows.
> * A failed upload, or an invalid or oversized inline image, shows a clear
> message. It never silently publishes a missing image.
> * Valid inline images render in the bundled themes. Non-image data URLs and
> active content stay blocked.
> * The docs say that custom themes with their own CSP must allow {{data:}}
> under {{img-src}}.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)