This is an automated email from the ASF dual-hosted git repository.

snoopdave pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/roller.git


The following commit(s) were added to refs/heads/master by this push:
     new cd6ed2778 Stop the release check reporting LICENSE and NOTICE missing 
from large archives
cd6ed2778 is described below

commit cd6ed2778bd2e9770316e583d36542b12ff993db
Author: David M. Johnson <[email protected]>
AuthorDate: Thu Oct 29 23:33:25 2026 -0400

    Stop the release check reporting LICENSE and NOTICE missing from large 
archives
    
    With pipefail, grep -q stops reading at the first match, printf gets
    SIGPIPE, and the pipeline fails even though the file was found. The
    source archive's listing is long enough to trigger it.
---
 skills/roller-release/scripts/check-release.sh | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/skills/roller-release/scripts/check-release.sh 
b/skills/roller-release/scripts/check-release.sh
index 63e8e1010..bad183cdc 100755
--- a/skills/roller-release/scripts/check-release.sh
+++ b/skills/roller-release/scripts/check-release.sh
@@ -153,7 +153,9 @@ for f in "${archives[@]}"; do
     names=$(list_archive "$f")
 
     for required in LICENSE NOTICE; do
-        if printf '%s\n' "$names" | grep -qE "(^|/)$required(\.txt)?$"; then
+        # not grep -q: it stops reading at the first match, printf then gets
+        # SIGPIPE, and pipefail turns a found file into a failure
+        if printf '%s\n' "$names" | grep -E "(^|/)$required(\.txt)?$" 
>/dev/null; then
             pass "$base contains $required"
         else
             bad "$base is missing $required"

Reply via email to