This is an automated email from the ASF dual-hosted git repository.

mraible pushed a commit to branch keep-comment-plugins-6.1.x
in repository https://gitbox.apache.org/repos/asf/roller.git

commit 84c5f5b40b6f763c837746cff95942321108cab7
Author: Matt Raible <[email protected]>
AuthorDate: Wed Nov 18 10:37:49 2026 -0700

    Keep the enabled comment plugins checked in Server Admin > Configuration
    
    The comment plugin checkbox list set value="name", which doesn't evaluate 
to the enabled plugin ids, so every box showed unchecked. Saving the page then 
stored an empty plugin list, which turned off HTMLSubset, the default comment 
plugin, and every other comment plugin site-wide. Without the value attribute, 
the list checks the plugins in commentPlugins, which the action loads from 
users.comments.plugins.
---
 app/src/main/webapp/WEB-INF/jsps/admin/GlobalConfig.jsp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/app/src/main/webapp/WEB-INF/jsps/admin/GlobalConfig.jsp 
b/app/src/main/webapp/WEB-INF/jsps/admin/GlobalConfig.jsp
index 45c399b30..ec013b7bb 100644
--- a/app/src/main/webapp/WEB-INF/jsps/admin/GlobalConfig.jsp
+++ b/app/src/main/webapp/WEB-INF/jsps/admin/GlobalConfig.jsp
@@ -34,7 +34,7 @@
             <%-- special case for comment plugins --%>
             <s:if test="#pd.name == 'users.comments.plugins'">
                 <s:checkboxlist label="%{getText(#pd.key)}" 
name="commentPlugins"
-                                list="pluginsList" listKey="id" value="name" 
listValue="name"/>
+                                list="pluginsList" listKey="id" 
listValue="name"/>
             </s:if>
 
             <%-- special case for front page blog --%>

Reply via email to