This is an automated email from the ASF dual-hosted git repository.
mraible pushed a change to branch account-and-search-hardening
in repository https://gitbox.apache.org/repos/asf/roller.git
from ba8f05177 Key Members page rows by permission so disabled members can
be changed
add 8b85935a6 Start the Docker image's Tomcat with -XX:-UseBASE64Intrinsics
add 58909ba7f Merge pull request #311 from apache/disable-base64-intrinsics
add adc487c63 Check the salt of multipart posts that Struts couldn't fully
parse
add a6331bf6c Merge pull request #312 from
apache/check-salt-on-multipart-errors
add fff56e2a4 Limit the size and download time of feeds fetched by the
planet aggregator
add 976f1fab7 Merge pull request #314 from apache/planet-fetch-limits
add c154ca8e8 Give OIDC accounts a 64-character random password BCrypt
accepts
add bc0216af5 Merge pull request #323 from
apache/oidc-placeholder-password-length
add 7171e10f8 Serve a media file only at its own weblog's address
add fe893f659 Merge pull request #308 from apache/media-file-own-weblog
add 78eccc231 Remove media pages nothing links to
add 9908e1d9b Merge pull request #309 from apache/remove-unused-media-pages
add 4bfd8d2fa Don't start a session for Roller UI stylesheets, scripts and
images
add f3bb36ba3 Skip the salt for Roller UI theme images too, and check that
static files still reach the filter chain
add 333f37b35 Merge pull request #310 from apache/no-salt-for-static-files
add cf6c76d0b List the RC2 fixes in CHANGES
add 282bd4ffc Add the site URL change to CHANGES
add a8cc11b86 Update the site URL entry for the per-host cache and admin
save
add b873b8c2a Update CHANGES for the review: site URL guidance, password
rule, LDAP escaping and static files
add e98c9f45f Describe what waits for the site URL while it's unset
add 72ca5911e Say that addNofollow uses jsoup and normalizes its output
add e12c34a45 List the jsoup HTML subset in CHANGES
add 740410236 Merge pull request #324 from apache/changes-for-rc2-fixes
add f05b3cfe2 Add the Docker image's Base64 option to any CATALINA_OPTS
passed in
add 9ff9162ea Say that a CATALINA_OPTS passed to the container is added to
the Base64 option
add e3f8fa996 Merge pull request #338 from
apache/base64-option-adds-to-catalina-opts
add fb7728d28 Keep the enabled comment plugins checked in Server Admin >
Configuration
add 486520ef5 Merge pull request #354 from apache/keep-comment-plugins
add 4a15bae47 Have Dependabot propose weekly version updates with a
72-hour cooldown
add 037e41c03 Let Dependabot propose major PostgreSQL updates for the
compose stack
add d49a8b7fe Merge pull request #352 from apache/dependabot-config
add f32f6e0f7 Update the test plugins, Playwright and the dev Keycloak
image
add bd62dd56f Run the compose stack's PostgreSQL on 18
add b6a957f53 Merge pull request #351 from apache/dependency-updates-rc2
add 7cc89aa52 Name the app that reports each required check
add d7995cbc5 Give release branches their own ruleset without required
checks
add e8cc9c67b Require review conversations to be resolved before a merge
add 53868dd85 Merge pull request #305 from apache/fix-required-check-app
add cfb28cc49 Don't match the external-login placeholder as a password
add fa368f39b Reject the external-login placeholder as a chosen password
and never match an empty one
add 66b8da5dc Merge remote-tracking branch 'origin/master' into
external-login-placeholder
add 959a35144 Don't let a stored external-login marker reach the delegate
encoder
add 2e66914e5 Make registration null-safe and use one external-login
marker for remember-me
add 67ddae8d8 Merge pull request #304 from
apache/external-login-placeholder
add 3b37370ee Escape user names, commenter details and tag names where
they are output
add bc98f9c8c Escape comments unless they are HTML restricted by the
HTMLSubset plugin
add 9a7e9ae90 Show comment and media file authors once-escaped in feeds
and keep existing rel values in addNofollow
add c8b9e6257 Find the link's own rel attribute when adding nofollow
add 91b5cf046 Use jsoup to add nofollow to links
add 6d9f0775e Leave feed author names empty when the name is missing
add 2b91937b9 Merge pull request #318 from apache/escape-user-display-names
add 2be6137de Include the page number in feed cache keys and limit page
numbers
add 1f8c6b5b1 Encode search terms and tag names in feed cache keys
add c2c618a5e Limit search and tag data page numbers and stop Next links
at the page limit
add 769ff6112 Leave the skipCache parameter out of page cache keys
add e4d3d16aa Fix feed pager links with extra parameters and the tag data
page size
add 428958bf5 Merge pull request #313 from apache/feed-cache-page-key
add 0fdc945a7 Check publish permission, upload size, scheduling and author
email in AtomPub
add 7630b5201 Reconcile tag counts when an edit changes publication state
add 0655d99cc Keep publish time, pending status and scheduling consistent
in AtomPub and XML-RPC edits
add ee094c01d Let a draft AtomPub update take a pending entry out of
review again
add 27ec93680 Merge pull request #316 from apache/atompub-permission-checks
add 8032cff88 Take the site URL from setup, not from the first request
add 004413fce Cache pages per host while the site URL is unset, and save
it from an admin's request
add a2804b26d Keep each request's site URL fixed while it renders, and
save the URL only once
add 9fb2bb512 Build links in emails only from the configured site URL
add 5d5b154e9 Wait for the site URL before syncing local weblogs into the
planet
add a4d494fa6 Don't save a local or internal address as the site URL
add e709ce4b5 Name the Server Admin tab as the UI does in site URL messages
add e64f88624 Set the site URL in the local planet refresh test
add 8c9ddcdc3 Use a neutral host name in the site URL mail tests
add d6c2fcef4 Report an unset site URL honestly when adding local feeds
and registering
add 7f8f5fc95 Merge pull request #320 from apache/absolute-url-from-config
add be0ad4ec9 Check a salt that was read from an upload with parse errors
add e0177538f Keep a valid salt when an upload has parse errors
add 632fce2d9 Merge pull request #339 from
apache/check-salt-sent-with-upload-errors
add 9b004d26b Keep interrupts, check the HTTP status and stop abandoned
feed downloads
add 9c726f07a Stop fetching feeds once interrupted and report the intended
fetch error
add 2403ec92d Merge pull request #340 from
apache/planet-fetch-status-and-interrupts
add 8af4a0aff Look a media file up in the addressed weblog before loading
its content
add 365d85085 Merge pull request #341 from apache/scoped-media-file-lookup
add 41b48d86d Remove the overlay mode flag and the external media include
page
add cf67ddb8a Merge pull request #342 from
apache/remove-unused-media-overlay-code
add c9ec79ca9 Keep the PostgreSQL 18 data directory out of the Docker
build context
add 353060692 Merge pull request #363 from
apache/dockerignore-postgresql-18-data
add 6e08db6bd Merge remote-tracking branch 'origin/master' into
account-and-search-hardening
No new revisions were added by this update.
Summary of changes:
.asf.yaml | 67 ++-
.dockerignore | 1 +
.github/dependabot.yml | 73 +++
.gitignore | 1 +
CHANGES.md | 81 ++++
app/pom.xml | 9 +-
.../planet/business/MultiPlanetURLStrategy.java | 2 +-
.../planet/business/fetcher/RomeFeedFetcher.java | 202 ++++++++-
.../updater/SingleThreadedFeedUpdater.java | 6 +
.../business/jpa/JPAWeblogEntryManagerImpl.java | 58 ++-
.../weblogger/config/WebloggerRuntimeConfig.java | 254 ++++++++++-
.../planet/business/PlanetURLStrategy.java | 2 +-
.../planet/business/WebloggerRomeFeedFetcher.java | 24 +
.../weblogger/planet/tasks/SyncWebsitesTask.java | 10 +
.../weblogger/planet/ui/PlanetGroupSubs.java | 4 +-
.../weblogger/pojos/wrapper/UserWrapper.java | 25 +-
.../pojos/wrapper/WeblogEntryCommentWrapper.java | 36 +-
.../weblogger/ui/core/filters/InitFilter.java | 111 ++---
.../weblogger/ui/core/filters/LoadSaltFilter.java | 20 +-
.../weblogger/ui/core/filters/SaltValidator.java | 19 +-
.../ui/core/security/CustomUserRegistry.java | 2 +-
.../ui/core/security/RollerPasswordEncoders.java | 70 ++-
.../ui/core/security/RollerRememberMeServices.java | 2 +-
.../ui/rendering/model/UtilitiesModel.java | 6 +-
.../ui/rendering/pagers/AbstractPager.java | 27 +-
.../pagers/AbstractWeblogEntriesPager.java | 14 +-
.../ui/rendering/pagers/SearchResultsPager.java | 3 +-
.../weblogger/ui/rendering/pagers/UsersPager.java | 2 +-
.../ui/rendering/pagers/WeblogEntriesDayPager.java | 2 +-
.../rendering/pagers/WeblogEntriesMonthPager.java | 2 +-
.../ui/rendering/pagers/WeblogsPager.java | 2 +-
.../rendering/servlets/MediaResourceServlet.java | 6 +
.../ui/rendering/servlets/PageServlet.java | 6 +-
.../ui/rendering/util/WeblogFeedRequest.java | 8 +-
.../ui/rendering/util/WeblogPageRequest.java | 12 +-
.../weblogger/ui/rendering/util/WeblogRequest.java | 28 +-
.../ui/rendering/util/WeblogSearchRequest.java | 9 +-
.../ui/rendering/util/cache/PlanetCache.java | 10 +-
.../ui/rendering/util/cache/SiteWideCache.java | 25 +-
.../rendering/util/cache/WeblogCacheWarmupJob.java | 8 +
.../ui/rendering/util/cache/WeblogFeedCache.java | 27 +-
.../ui/rendering/util/cache/WeblogPageCache.java | 10 +-
.../weblogger/ui/struts2/admin/UserEdit.java | 8 +-
.../ui/struts2/ajax/CommentDataServlet.java | 7 +-
.../weblogger/ui/struts2/ajax/UserDataServlet.java | 2 +
.../roller/weblogger/ui/struts2/core/Install.java | 19 +
.../roller/weblogger/ui/struts2/core/Profile.java | 8 +-
.../roller/weblogger/ui/struts2/core/Register.java | 59 ++-
.../weblogger/ui/struts2/editor/MediaFileAdd.java | 6 +-
.../weblogger/ui/struts2/editor/MediaFileBase.java | 492 ++++++++++-----------
.../ui/struts2/editor/MediaFileImageDim.java | 73 ---
.../ui/struts2/util/UIActionInterceptor.java | 6 +
.../ui/struts2/util/ValidateSaltInterceptor.java | 24 +-
.../org/apache/roller/weblogger/util/MailUtil.java | 108 +++--
.../apache/roller/weblogger/util/Utilities.java | 58 +--
.../webservices/atomprotocol/EntryCollection.java | 34 +-
.../webservices/atomprotocol/MediaCollection.java | 55 ++-
.../webservices/tagdata/TagDataServlet.java | 32 +-
.../webservices/xmlrpc/BloggerAPIHandler.java | 23 +
.../webservices/xmlrpc/MetaWeblogAPIHandler.java | 11 +-
.../main/resources/ApplicationResources.properties | 7 +
.../roller/weblogger/config/roller.properties | 5 +
app/src/main/resources/struts.xml | 25 --
.../webapp/WEB-INF/jsps/admin/GlobalConfig.jsp | 2 +-
.../webapp/WEB-INF/jsps/admin/PlanetGroupSubs.jsp | 8 +-
.../webapp/WEB-INF/jsps/admin/PlanetGroups.jsp | 6 +-
.../main/webapp/WEB-INF/jsps/editor/Comments.jsp | 4 +-
.../jsps/editor/MediaFileAddExternalInclude.jsp | 63 ---
.../jsps/editor/MediaFileAddSuccessInclude.jsp | 30 --
.../jsps/editor/MediaFileImageDimension.jsp | 104 -----
app/src/main/webapp/WEB-INF/tiles.xml | 20 -
app/src/main/webapp/WEB-INF/velocity/feeds.vm | 12 +-
.../fetcher/RomeFeedFetcherLimitsTest.java | 342 ++++++++++++++
.../weblogger/business/PlanetManagerLocalTest.java | 22 +-
.../roller/weblogger/business/PropertiesTest.java | 56 +++
.../weblogger/config/SiteUrlForAdminTest.java | 168 +++++++
.../weblogger/config/SiteUrlWhileUnsetTest.java | 171 +++++++
.../planet/business/PlanetSiteUrlTest.java | 125 ++++++
.../weblogger/pojos/wrapper/UserWrapperTest.java | 67 +++
.../wrapper/WeblogEntryCommentWrapperTest.java | 70 +++
.../weblogger/ui/core/filters/InitFilterTest.java | 203 +++++++--
.../ui/core/filters/LoadSaltFilterTest.java | 36 ++
.../security/ExternalLoginPlaceholderTest.java | 233 ++++++++++
.../ui/core/security/RandomUnusedPasswordTest.java | 51 +++
.../rendering/pagers/FeedPagerLinkParamsTest.java | 141 ++++++
.../rendering/pagers/PagerNextLinkLimitTest.java | 127 ++++++
...vletTest.java => MediaResourceServletTest.java} | 111 ++---
.../rendering/servlets/PageServletCacheTest.java | 127 ++++++
.../ui/rendering/util/PageParameterTest.java | 112 +++++
.../util/cache/WeblogFeedCacheKeyTest.java | 111 +++++
.../rendering/velocity/FeedAuthorEscapingTest.java | 311 +++++++++++++
.../ui/struts2/ajax/CommentDataServletTest.java | 43 ++
.../ui/struts2/ajax/UserDataServletTest.java | 24 +-
.../core/ExternalLoginMarkerPasswordTest.java | 217 +++++++++
.../weblogger/ui/struts2/core/InstallTest.java | 59 +++
.../ui/struts2/core/RegisterSiteUrlTest.java | 204 +++++++++
.../struts2/editor/AuthoringActionScopingTest.java | 8 -
.../ui/struts2/util/JspOutputEncodingTest.java | 20 +
.../util/StrutsParameterAnnotationTest.java | 4 +-
.../struts2/util/ValidateSaltInterceptorTest.java | 95 +++-
.../util/MailUtilCommentNotificationTest.java | 100 +++++
.../roller/weblogger/util/MailUtilSiteUrlTest.java | 240 ++++++++++
.../roller/weblogger/util/UtilitiesTest.java | 84 +++-
.../EntryCollectionPermissionTest.java | 354 +++++++++++++++
.../atomprotocol/MediaCollectionPathTest.java | 28 ++
.../atomprotocol/RollerAtomProtocolTest.java | 86 ++++
.../tagdata/TagDataServletPageTest.java | 148 +++++++
.../webservices/tagdata/TagDataServletTest.java | 122 +++++
.../xmlrpc/XMLRPCWeblogPermissionTest.java | 143 ++++++
binary-includes/LICENSE.txt | 5 +
docker-compose.yml | 16 +-
docker/entry-point.sh | 7 +
docs/roller-install-guide.adoc | 6 +-
it-playwright/pom.xml | 6 +-
.../apache/roller/playwright/NewUserJourneyIT.java | 5 +
115 files changed, 6188 insertions(+), 1017 deletions(-)
create mode 100644 .github/dependabot.yml
delete mode 100644
app/src/main/java/org/apache/roller/weblogger/ui/struts2/editor/MediaFileImageDim.java
delete mode 100644
app/src/main/webapp/WEB-INF/jsps/editor/MediaFileAddExternalInclude.jsp
delete mode 100644
app/src/main/webapp/WEB-INF/jsps/editor/MediaFileAddSuccessInclude.jsp
delete mode 100644
app/src/main/webapp/WEB-INF/jsps/editor/MediaFileImageDimension.jsp
create mode 100644
app/src/test/java/org/apache/roller/planet/business/fetcher/RomeFeedFetcherLimitsTest.java
create mode 100644
app/src/test/java/org/apache/roller/weblogger/config/SiteUrlForAdminTest.java
create mode 100644
app/src/test/java/org/apache/roller/weblogger/config/SiteUrlWhileUnsetTest.java
create mode 100644
app/src/test/java/org/apache/roller/weblogger/planet/business/PlanetSiteUrlTest.java
create mode 100644
app/src/test/java/org/apache/roller/weblogger/pojos/wrapper/UserWrapperTest.java
create mode 100644
app/src/test/java/org/apache/roller/weblogger/ui/core/security/ExternalLoginPlaceholderTest.java
create mode 100644
app/src/test/java/org/apache/roller/weblogger/ui/core/security/RandomUnusedPasswordTest.java
create mode 100644
app/src/test/java/org/apache/roller/weblogger/ui/rendering/pagers/FeedPagerLinkParamsTest.java
create mode 100644
app/src/test/java/org/apache/roller/weblogger/ui/rendering/pagers/PagerNextLinkLimitTest.java
copy
app/src/test/java/org/apache/roller/weblogger/ui/rendering/servlets/{ResourceServletTest.java
=> MediaResourceServletTest.java} (54%)
create mode 100644
app/src/test/java/org/apache/roller/weblogger/ui/rendering/servlets/PageServletCacheTest.java
create mode 100644
app/src/test/java/org/apache/roller/weblogger/ui/rendering/util/PageParameterTest.java
create mode 100644
app/src/test/java/org/apache/roller/weblogger/ui/rendering/util/cache/WeblogFeedCacheKeyTest.java
create mode 100644
app/src/test/java/org/apache/roller/weblogger/ui/rendering/velocity/FeedAuthorEscapingTest.java
create mode 100644
app/src/test/java/org/apache/roller/weblogger/ui/struts2/core/ExternalLoginMarkerPasswordTest.java
create mode 100644
app/src/test/java/org/apache/roller/weblogger/ui/struts2/core/RegisterSiteUrlTest.java
create mode 100644
app/src/test/java/org/apache/roller/weblogger/util/MailUtilCommentNotificationTest.java
create mode 100644
app/src/test/java/org/apache/roller/weblogger/util/MailUtilSiteUrlTest.java
create mode 100644
app/src/test/java/org/apache/roller/weblogger/webservices/atomprotocol/EntryCollectionPermissionTest.java
create mode 100644
app/src/test/java/org/apache/roller/weblogger/webservices/tagdata/TagDataServletPageTest.java
create mode 100644
app/src/test/java/org/apache/roller/weblogger/webservices/tagdata/TagDataServletTest.java