This is an automated email from the ASF dual-hosted git repository.

pent pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/royale-asjs.git


The following commit(s) were added to refs/heads/develop by this push:
     new 9c25b2b  Only set up CollectionEvent listener when there is an actual 
ArrayList dataProvider present in the model.
9c25b2b is described below

commit 9c25b2be47c8a3ec318fac677fa80afa49d77872
Author: Peter Ent <[email protected]>
AuthorDate: Sat Dec 9 15:08:44 2017 -0500

    Only set up CollectionEvent listener when there is an actual ArrayList 
dataProvider present in the model.
---
 .../beads/DynamicItemsRendererFactoryForArrayListData.as     | 12 +++++-------
 1 file changed, 5 insertions(+), 7 deletions(-)

diff --git 
a/frameworks/projects/Basic/src/main/royale/org/apache/royale/html/beads/DynamicItemsRendererFactoryForArrayListData.as
 
b/frameworks/projects/Basic/src/main/royale/org/apache/royale/html/beads/DynamicItemsRendererFactoryForArrayListData.as
index 43bc59f..acf121c 100644
--- 
a/frameworks/projects/Basic/src/main/royale/org/apache/royale/html/beads/DynamicItemsRendererFactoryForArrayListData.as
+++ 
b/frameworks/projects/Basic/src/main/royale/org/apache/royale/html/beads/DynamicItemsRendererFactoryForArrayListData.as
@@ -91,14 +91,9 @@ package org.apache.royale.html.beads
             var listView:IListView = _strand.getBeadByType(IListView) as 
IListView;
             dataGroup = listView.dataGroup;
             dataProviderModel.addEventListener("dataProviderChanged", 
dataProviderChangeHandler);
+                       labelField = dataProviderModel.labelField;
                        
-                       // also listen for individual items being added to the 
dataProvider itself.
-                       var dataProvider:IEventDispatcher = 
dataProviderModel.dataProvider as IEventDispatcher;
-            dataProvider.addEventListener(CollectionEvent.ITEM_ADDED, 
itemAddedHandler);
-
-            labelField = dataProviderModel.labelField;
-
-            dataProviderChangeHandler(null);
+                       dataProviderChangeHandler(null);
         }
                
                protected var _dataProviderModel:ISelectionModel;
@@ -163,6 +158,9 @@ package org.apache.royale.html.beads
             if (!dp)
                 return;
 
+                       // listen for individual items being added in the 
future.
+                       (dp as 
IEventDispatcher).addEventListener(CollectionEvent.ITEM_ADDED, 
itemAddedHandler);
+                       
             dataGroup.removeAllItemRenderers();
 
             var presentationModel:IListPresentationModel = 
_strand.getBeadByType(IListPresentationModel) as IListPresentationModel;

-- 
To stop receiving notification emails like this one, please contact
['"[email protected]" <[email protected]>'].

Reply via email to