This is an automated email from the ASF dual-hosted git repository.
aharui pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/royale-asjs.git
commit dfc85d6497e48dec75f7cc97fb5392c3cd2edbcf
Author: Alex Harui <aha...@apache.org>
AuthorDate: Thu Feb 22 22:29:52 2018 -0800
watch out for private property collisions in JS
---
.../Effects/src/main/royale/org/apache/royale/effects/Fade.as | 8 +++++---
.../Effects/src/main/royale/org/apache/royale/effects/Move.as | 8 +++++---
.../Effects/src/main/royale/org/apache/royale/effects/Resize.as | 8 +++++---
.../Effects/src/main/royale/org/apache/royale/effects/Wipe.as | 8 +++++---
4 files changed, 20 insertions(+), 12 deletions(-)
diff --git
a/frameworks/projects/Effects/src/main/royale/org/apache/royale/effects/Fade.as
b/frameworks/projects/Effects/src/main/royale/org/apache/royale/effects/Fade.as
index dae391c..94eafed 100644
---
a/frameworks/projects/Effects/src/main/royale/org/apache/royale/effects/Fade.as
+++
b/frameworks/projects/Effects/src/main/royale/org/apache/royale/effects/Fade.as
@@ -80,7 +80,9 @@ public class Fade extends Tween implements IDocument
*/
private var actualTarget:IUIBase;
- private var _target:String;
+ // there is already a _target in the base class
+ // and JS can't hide it
+ private var target_:String;
/**
* The target as the String id
@@ -88,12 +90,12 @@ public class Fade extends Tween implements IDocument
*/
public function get target():String
{
- return _target;
+ return target_;
}
public function set target(value:String):void
{
- _target = value;
+ target_ = value;
}
/**
diff --git
a/frameworks/projects/Effects/src/main/royale/org/apache/royale/effects/Move.as
b/frameworks/projects/Effects/src/main/royale/org/apache/royale/effects/Move.as
index 6081e87..b64be13 100644
---
a/frameworks/projects/Effects/src/main/royale/org/apache/royale/effects/Move.as
+++
b/frameworks/projects/Effects/src/main/royale/org/apache/royale/effects/Move.as
@@ -80,7 +80,9 @@ public class Move extends Tween implements IDocument
*/
private var actualTarget:IUIBase;
- private var _target:String;
+ // there is already a _target in the base class
+ // and JS can't hide it
+ private var target_:String;
/**
* The target as the String id
@@ -88,12 +90,12 @@ public class Move extends Tween implements IDocument
*/
public function get target():String
{
- return _target;
+ return target_;
}
public function set target(value:String):void
{
- _target = value;
+ target_ = value;
}
private var _xBy:Number;
diff --git
a/frameworks/projects/Effects/src/main/royale/org/apache/royale/effects/Resize.as
b/frameworks/projects/Effects/src/main/royale/org/apache/royale/effects/Resize.as
index cffca8f..b4d824d 100644
---
a/frameworks/projects/Effects/src/main/royale/org/apache/royale/effects/Resize.as
+++
b/frameworks/projects/Effects/src/main/royale/org/apache/royale/effects/Resize.as
@@ -80,7 +80,9 @@ public class Resize extends Tween implements IDocument
*/
private var actualTarget:IUIBase;
- private var _target:String;
+ // there is already a _target in the base class
+ // and JS can't hide it
+ private var target_:String;
/**
* The target as the String id
@@ -88,12 +90,12 @@ public class Resize extends Tween implements IDocument
*/
public function get target():String
{
- return _target;
+ return target_;
}
public function set target(value:String):void
{
- _target = value;
+ target_ = value;
}
private var _widthBy:Number;
diff --git
a/frameworks/projects/Effects/src/main/royale/org/apache/royale/effects/Wipe.as
b/frameworks/projects/Effects/src/main/royale/org/apache/royale/effects/Wipe.as
index 15060a0..4289231 100644
---
a/frameworks/projects/Effects/src/main/royale/org/apache/royale/effects/Wipe.as
+++
b/frameworks/projects/Effects/src/main/royale/org/apache/royale/effects/Wipe.as
@@ -79,7 +79,9 @@ public class Wipe extends Tween implements IDocument
*/
private var actualTarget:IUIBase;
- private var _target:String;
+ // there is already a _target in the base class
+ // and JS can't hide it
+ private var target_:String;
/**
* The target as the String id
@@ -87,12 +89,12 @@ public class Wipe extends Tween implements IDocument
*/
public function get target():String
{
- return _target;
+ return target_;
}
public function set target(value:String):void
{
- _target = value;
+ target_ = value;
}
private var _direction:String;
--
To stop receiving notification emails like this one, please contact
aha...@apache.org.
