This is an automated email from the ASF dual-hosted git repository.

yishayw pushed a commit to branch feature/revert-refactor
in repository https://gitbox.apache.org/repos/asf/royale-asjs.git


The following commit(s) were added to refs/heads/feature/revert-refactor by 
this push:
     new 20ad3e1  Make color values consistent with opacity, a decimal between 
0 and 1.
     new 1cb7aee  Merge branch 'feature/revert-refactor' of 
https://github.com/apache/royale-asjs into feature/revert-refactor
20ad3e1 is described below

commit 20ad3e178ed0db8d0d1d32a65bd654e535c7b4fd
Author: DESKTOP-RH4S838\Yishay <[email protected]>
AuthorDate: Tue Jul 10 13:45:32 2018 +0300

    Make color values consistent with opacity, a decimal between 0 and 1.
---
 .../royale/org/apache/royale/svg/ColorMatrixFilterElement.as   | 10 +++++-----
 .../src/main/royale/org/apache/royale/svg/DropShadowFilter.as  |  8 ++++----
 2 files changed, 9 insertions(+), 9 deletions(-)

diff --git 
a/frameworks/projects/Graphics/src/main/royale/org/apache/royale/svg/ColorMatrixFilterElement.as
 
b/frameworks/projects/Graphics/src/main/royale/org/apache/royale/svg/ColorMatrixFilterElement.as
index 5e38562..924edb7 100644
--- 
a/frameworks/projects/Graphics/src/main/royale/org/apache/royale/svg/ColorMatrixFilterElement.as
+++ 
b/frameworks/projects/Graphics/src/main/royale/org/apache/royale/svg/ColorMatrixFilterElement.as
@@ -54,13 +54,13 @@ package org.apache.royale.svg
                        super.onInitComplete(e);
                        COMPILE::JS 
                        {
-                               var matrixValues:String = "0 0 0 0 " + red / 
255 + " 0 0 0 0 " + green  / 255 + " 0 0 0 0 " + blue / 255 + " 0 0 0 " + 
opacity + " 0";
+                               var matrixValues:String = "0 0 0 0 " + red + " 
0 0 0 0 " + green + " 0 0 0 0 " + blue + " 0 0 0 " + opacity + " 0";
                                filterElement.setAttribute("values", 
matrixValues);
                        }
                }
 
                /**
-                *  The red value
+                *  The red value. This should be a number between 0 and 1.
                 *
                 *  @langversion 3.0
                 *  @playerversion Flash 10.2
@@ -78,7 +78,7 @@ package org.apache.royale.svg
                }
 
                /**
-                *  The blue value
+                *  The blue value. This should be a number between 0 and 1.
                 *
                 *  @langversion 3.0
                 *  @playerversion Flash 10.2
@@ -96,7 +96,7 @@ package org.apache.royale.svg
                }
 
                /**
-                *  The green value
+                *  The green value. This should be a number between 0 and 1.
                 *
                 *  @langversion 3.0
                 *  @playerversion Flash 10.2
@@ -114,7 +114,7 @@ package org.apache.royale.svg
                }
 
                /**
-                *  The opacity value
+                *  The opacity value. This should be a number between 0 and 1.
                 *
                 *  @langversion 3.0
                 *  @playerversion Flash 10.2
diff --git 
a/frameworks/projects/Graphics/src/main/royale/org/apache/royale/svg/DropShadowFilter.as
 
b/frameworks/projects/Graphics/src/main/royale/org/apache/royale/svg/DropShadowFilter.as
index aa3f06a..f974de4 100644
--- 
a/frameworks/projects/Graphics/src/main/royale/org/apache/royale/svg/DropShadowFilter.as
+++ 
b/frameworks/projects/Graphics/src/main/royale/org/apache/royale/svg/DropShadowFilter.as
@@ -192,7 +192,7 @@ package org.apache.royale.svg
                }
 
                /**
-                *  The red component of the drop shadow
+                *  The red component of the drop shadow. This should be a 
number between 0 and 1.
                 *
                 *  @langversion 3.0
                 *  @playerversion Flash 10.2
@@ -210,7 +210,7 @@ package org.apache.royale.svg
                }
 
                /**
-                *  The green component of the drop shadow
+                *  The green component of the drop shadow. This should be a 
number between 0 and 1.
                 *
                 *  @langversion 3.0
                 *  @playerversion Flash 10.2
@@ -228,7 +228,7 @@ package org.apache.royale.svg
                }
 
                /**
-                *  The blue component of the drop shadow
+                *  The blue component of the drop shadow. This should be a 
number between 0 and 1.
                 *
                 *  @langversion 3.0
                 *  @playerversion Flash 10.2
@@ -246,7 +246,7 @@ package org.apache.royale.svg
                }
 
                /**
-                *  The opacity component of the drop shadow
+                *  The opacity component of the drop shadow. This should be a 
number between 0 and 1.
                 *
                 *  @langversion 3.0
                 *  @playerversion Flash 10.2

Reply via email to