[royale-asjs] branch develop updated: jewel-alert: now that we can have @externs in libraries with source maps turned on, we can use dialogPolyfill.registerDialog() call instead of window["dialogPolyfill"]["registerDialog"](dialog);

[carlosrovira]

This is an automated email from the ASF dual-hosted git repository.

carlosrovira pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/royale-asjs.git


The following commit(s) were added to refs/heads/develop by this push:
     new 813b470  jewel-alert: now that we can have @externs in libraries with 
source maps turned on, we can use dialogPolyfill.registerDialog() call instead 
of  window["dialogPolyfill"]["registerDialog"](dialog);
813b470 is described below

commit 813b470b4a01e5fa34758bb0de3e338591a2a347
Author: Carlos Rovira <carlosrov...@apache.org>
AuthorDate: Sun Jun 2 18:15:17 2019 +0200

    jewel-alert: now that we can have @externs in libraries with source maps 
turned on, we can use dialogPolyfill.registerDialog() call instead of  
window["dialogPolyfill"]["registerDialog"](dialog);
---
 frameworks/projects/Jewel/src/main/royale/dialogPolyfill.as            | 2 +-
 .../projects/Jewel/src/main/royale/org/apache/royale/jewel/Alert.as    | 3 +--
 2 files changed, 2 insertions(+), 3 deletions(-)

diff --git a/frameworks/projects/Jewel/src/main/royale/dialogPolyfill.as 
b/frameworks/projects/Jewel/src/main/royale/dialogPolyfill.as
index e8cf91e..10323a8 100644
--- a/frameworks/projects/Jewel/src/main/royale/dialogPolyfill.as
+++ b/frameworks/projects/Jewel/src/main/royale/dialogPolyfill.as
@@ -24,6 +24,6 @@ package
        public class dialogPolyfill
        {
                COMPILE::JS
-               public static function 
registerDialog(dialog:HTMLDialogElement):void {}
+               public static function registerDialog(dialog:Element):void {}
        }
 }
\ No newline at end of file
diff --git 
a/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/Alert.as 
b/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/Alert.as
index 928f918..9c22299 100644
--- a/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/Alert.as
+++ b/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/Alert.as
@@ -222,8 +222,7 @@ package org.apache.royale.jewel
                                        
                                        if (!("showModal" in dialog))
                                        {
-                                               
window["dialogPolyfill"]["registerDialog"](dialog);
-                                               // 
dialogPolyfill.registerDialog(dialog);
+                                               
dialogPolyfill.registerDialog(dialog);
                                        }
 
                                        //avoid scroll in html