[royale-asjs] branch develop updated: jewel-modules: clean imports and avoid module to load by default. Users will not always want to load the module on addedToParent

[carlosrovira]

This is an automated email from the ASF dual-hosted git repository.

carlosrovira pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/royale-asjs.git


The following commit(s) were added to refs/heads/develop by this push:
     new 5705a7f  jewel-modules: clean imports and avoid module to load by 
default. Users will not always want to load the module on addedToParent
5705a7f is described below

commit 5705a7fc6b1847a7652c3997c37132fd9ed3dc2e
Author: Carlos Rovira <carlosrov...@apache.org>
AuthorDate: Wed Jun 19 20:50:22 2019 +0200

    jewel-modules: clean imports and avoid module to load by default. Users 
will not always want to load the module on addedToParent
---
 .../main/royale/org/apache/royale/jewel/Module.as   | 13 ++++++-------
 .../royale/org/apache/royale/jewel/ModuleLoader.as  | 21 +++++++++------------
 2 files changed, 15 insertions(+), 19 deletions(-)

diff --git 
a/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/Module.as 
b/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/Module.as
index 945d31a..3560965 100644
--- 
a/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/Module.as
+++ 
b/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/Module.as
@@ -18,17 +18,16 @@
 
////////////////////////////////////////////////////////////////////////////////
 package org.apache.royale.jewel
 {
+    import org.apache.royale.core.IFlexInfo;
+    import org.apache.royale.core.IModule;
+    import org.apache.royale.core.IValuesImpl;
+    import org.apache.royale.core.ValuesManager;
+
     COMPILE::SWF
     {
-        import flash.system.ApplicationDomain;        
+        import flash.system.ApplicationDomain;
         import flash.utils.getQualifiedClassName;        
     }
-    import org.apache.royale.core.IFlexInfo;
-    import org.apache.royale.core.IModule;
-    import org.apache.royale.core.IValuesImpl;
-       import org.apache.royale.core.ValuesManager;
-       import org.apache.royale.events.Event;
-       import org.apache.royale.events.ValueChangeEvent;
 
     /**
      *  Indicates that the state change has completed.  All properties
diff --git 
a/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/ModuleLoader.as
 
b/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/ModuleLoader.as
index bafdd97..83e1c72 100644
--- 
a/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/ModuleLoader.as
+++ 
b/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/ModuleLoader.as
@@ -18,31 +18,28 @@
 
////////////////////////////////////////////////////////////////////////////////
 package org.apache.royale.jewel
 {
-       import org.apache.royale.core.IUIBase;
        import org.apache.royale.core.StyledUIBase;
-       import org.apache.royale.utils.PointUtils;
-    import org.apache.royale.utils.UIModuleUtils;
-       import org.apache.royale.geom.Point;
-       import org.apache.royale.events.Event;
+       import org.apache.royale.utils.UIModuleUtils;
        
        COMPILE::SWF
        {
-               import flash.display.Loader;
                import flash.display.DisplayObjectContainer;
-        import flash.events.Event;
-               import flash.system.LoaderContext;
-               import flash.system.ApplicationDomain;
+               import flash.display.Loader;
+               import flash.events.Event;
                import flash.net.URLRequest;
+               import flash.system.ApplicationDomain;
+               import flash.system.LoaderContext;
        }
        
     COMPILE::JS
     {
         import goog.global;
+
         import org.apache.royale.core.WrappedHTMLElement;   
     }
     
     /**
-     *  The ModuleLoader class can load a Module. 
+     *  The Jewel ModuleLoader class can load a Jewel Module. 
         * 
      *  @toplevel
      *  @langversion 3.0
@@ -102,8 +99,8 @@ package org.apache.royale.jewel
         override public function addedToParent():void
         {
             super.addedToParent();
-            if (utils.moduleName)
-                loadModule();
+            // if (utils.moduleName)
+            //     loadModule();
         }
                
         private var utils:UIModuleUtils = new UIModuleUtils();