This is an automated email from the ASF dual-hosted git repository.
carlosrovira pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/royale-asjs.git
The following commit(s) were added to refs/heads/develop by this push:
new 7c32555 jewel-navigation: remove href since is not used anymore and
interferes with routing
7c32555 is described below
commit 7c32555d39170b9db0fb54df0dbe515c27bdff24
Author: Carlos Rovira <[email protected]>
AuthorDate: Wed Jan 22 19:11:44 2020 +0100
jewel-navigation: remove href since is not used anymore and interferes with
routing
---
.../itemRenderers/NavigationLinkItemRenderer.as | 36 +++++++++++-----------
.../jewel/supportClasses/INavigationRenderer.as | 4 +--
2 files changed, 20 insertions(+), 20 deletions(-)
diff --git
a/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/itemRenderers/NavigationLinkItemRenderer.as
b/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/itemRenderers/NavigationLinkItemRenderer.as
index 86f478c..cdf5574 100644
---
a/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/itemRenderers/NavigationLinkItemRenderer.as
+++
b/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/itemRenderers/NavigationLinkItemRenderer.as
@@ -59,7 +59,7 @@ package org.apache.royale.jewel.itemRenderers
}
}
- private var _href:String = "#";
+ // private var _href:String = "#";
/**
* the navigation link url
*
@@ -68,15 +68,15 @@ package org.apache.royale.jewel.itemRenderers
* @playerversion AIR 2.6
* @productversion Royale 0.9.4
*/
- [Bindable('dataChange')]
- public function get href():String
- {
- return _href;
- }
- public function set href(value:String):void
- {
- _href = value;
- }
+ // [Bindable('dataChange')]
+ // public function get href():String
+ // {
+ // return _href;
+ // }
+ // public function set href(value:String):void
+ // {
+ // _href = value;
+ // }
private var _text:String = "";
@@ -115,7 +115,7 @@ package org.apache.royale.jewel.itemRenderers
override public function set data(value:Object):void
{
if (value == null) {
- _href = "#";
+ // _href = "#";
_text = null;
//super.data setter will dispatch dataChange
super.data = value;
@@ -137,18 +137,18 @@ package org.apache.royale.jewel.itemRenderers
}
// text = getLabelFromData(this, value);
- if(value.href !== undefined)
- {
- if (value.href === null) _href = "#";
- else _href = String(value.href);
- } else _href = "#";
+ // if(value.href !== undefined)
+ // {
+ // if (value.href === null) _href = "#";
+ // else _href = String(value.href);
+ // } else _href = "#";
COMPILE::JS
{
if(textNode != null)
{
textNode.nodeValue = _text;
- (element as HTMLElement).setAttribute('href',
_href);
+ //(element as HTMLElement).setAttribute('href',
_href);
}
}
//super.data setter will dispatch dataChange
@@ -163,7 +163,7 @@ package org.apache.royale.jewel.itemRenderers
override protected function createElement():WrappedHTMLElement
{
var a:WrappedHTMLElement = addElementToWrapper(this, 'a');
- a.setAttribute('href', href);
+ //a.setAttribute('href', href);
if(MXMLDescriptor == null)
{
diff --git
a/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/supportClasses/INavigationRenderer.as
b/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/supportClasses/INavigationRenderer.as
index e0da1e6..c080487 100644
---
a/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/supportClasses/INavigationRenderer.as
+++
b/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/supportClasses/INavigationRenderer.as
@@ -42,7 +42,7 @@ package org.apache.royale.jewel.supportClasses
* @playerversion AIR 2.6
* @productversion Royale 0.9.4
*/
- function get href():String;
- function set href(value:String):void;
+ // function get href():String;
+ // function set href(value:String):void;
}
}
