This is an automated email from the ASF dual-hosted git repository.
carlosrovira pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/royale-asjs.git
The following commit(s) were added to refs/heads/develop by this push:
new 75800c1 jewel-renderers: remove href from INavigationRenders, since
navigation changed by content long ago
75800c1 is described below
commit 75800c1bb9a4b98a9ad4b3da8148052b4ef5e751
Author: Carlos Rovira <[email protected]>
AuthorDate: Thu Jan 23 00:36:30 2020 +0100
jewel-renderers: remove href from INavigationRenders, since navigation
changed by content long ago
---
.../CollapsibleNavigationSectionRenderer.as | 32 +++++++++++-----------
.../itemRenderers/TabBarButtonItemRenderer.as | 26 +++++++++---------
2 files changed, 29 insertions(+), 29 deletions(-)
diff --git
a/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/itemRenderers/CollapsibleNavigationSectionRenderer.as
b/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/itemRenderers/CollapsibleNavigationSectionRenderer.as
index 32d3f74..eae54f0 100644
---
a/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/itemRenderers/CollapsibleNavigationSectionRenderer.as
+++
b/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/itemRenderers/CollapsibleNavigationSectionRenderer.as
@@ -92,7 +92,7 @@ package org.apache.royale.jewel.itemRenderers
private var navLinkClassSelector:ClassSelectorList;
- private var _href:String = "#";
+ // private var _href:String = "#";
/**
* the navigation link url
* while the parent is primarily for hiding or showing its
@@ -106,14 +106,14 @@ package org.apache.royale.jewel.itemRenderers
* @playerversion AIR 2.6
* @productversion Royale 0.9.6
*/
- public function get href():String
- {
- return _href;
- }
- public function set href(value:String):void
- {
- _href = value;
- }
+ // public function get href():String
+ // {
+ // return _href;
+ // }
+ // public function set href(value:String):void
+ // {
+ // _href = value;
+ // }
private var _text:String = "";
@@ -228,7 +228,7 @@ package org.apache.royale.jewel.itemRenderers
override public function set data(value:Object):void
{
if(value == null) {
- _href = "#";
+ // _href = "#";
_text = null;
open = false;
//super.data setter will dispatch dataChange
@@ -250,17 +250,17 @@ package org.apache.royale.jewel.itemRenderers
}
// text = getLabelFromData(this, value);
- if(value.href !== undefined)
- {
- href = String(value.href);
- }
+ // if(value.href !== undefined)
+ // {
+ // href = String(value.href);
+ // }
COMPILE::JS
{
if(textNode != null)
{
textNode.nodeValue = text;
- (element as
HTMLElement).setAttribute('href', href);
+ // (element as
HTMLElement).setAttribute('href', href);
}
}
@@ -315,7 +315,7 @@ package org.apache.royale.jewel.itemRenderers
var nav:WrappedHTMLElement = addElementToWrapper(this,
'nav');
sectionNavItem = new A();
- sectionNavItem.href = href;
+ // sectionNavItem.href = href;
if(MXMLDescriptor == null)
{
textNode = document.createTextNode('') as Text;
diff --git
a/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/itemRenderers/TabBarButtonItemRenderer.as
b/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/itemRenderers/TabBarButtonItemRenderer.as
index adb2652..7b4a8e9 100644
---
a/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/itemRenderers/TabBarButtonItemRenderer.as
+++
b/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/itemRenderers/TabBarButtonItemRenderer.as
@@ -56,7 +56,7 @@ package org.apache.royale.jewel.itemRenderers
addClass("selectable");
}
- private var _href:String = "#";
+ // private var _href:String = "#";
/**
* the navigation link url
*
@@ -65,14 +65,14 @@ package org.apache.royale.jewel.itemRenderers
* @playerversion AIR 2.6
* @productversion Royale 0.9.4
*/
- public function get href():String
- {
- return _href;
- }
- public function set href(value:String):void
- {
- _href = value;
- }
+ // public function get href():String
+ // {
+ // return _href;
+ // }
+ // public function set href(value:String):void
+ // {
+ // _href = value;
+ // }
private var _text:String = "";
@@ -120,10 +120,10 @@ package org.apache.royale.jewel.itemRenderers
text = getLabelFromData(this, value);
super.data = value;
- if(value.href !== undefined)
- {
- href = String(value.href);
- }
+ // if(value.href !== undefined)
+ // {
+ // href = String(value.href);
+ // }
// COMPILE::JS
// {
