[royale-asjs] branch develop updated: todomvc-jewel: fix a bug where click outside was not working on sibling renderers due to useCapture not true

[carlosrovira]

This is an automated email from the ASF dual-hosted git repository.

carlosrovira pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/royale-asjs.git


The following commit(s) were added to refs/heads/develop by this push:
     new 2b2951e  todomvc-jewel: fix a bug where click outside was not working 
on sibling renderers due to useCapture not true
2b2951e is described below

commit 2b2951e471ccee2a315b03a8a2c1926f45bdd599
Author: Carlos Rovira <carlosrov...@apache.org>
AuthorDate: Sat Feb 1 17:18:07 2020 +0100

    todomvc-jewel: fix a bug where click outside was not working on sibling 
renderers due to useCapture not true
---
 .../main/royale/jewel/todomvc/renderers/TodoItemRenderer.mxml | 11 ++++++-----
 1 file changed, 6 insertions(+), 5 deletions(-)

diff --git 
a/examples/jewel/todomvc/src/main/royale/jewel/todomvc/renderers/TodoItemRenderer.mxml
 
b/examples/jewel/todomvc/src/main/royale/jewel/todomvc/renderers/TodoItemRenderer.mxml
index 6cd6f26..325215b 100644
--- 
a/examples/jewel/todomvc/src/main/royale/jewel/todomvc/renderers/TodoItemRenderer.mxml
+++ 
b/examples/jewel/todomvc/src/main/royale/jewel/todomvc/renderers/TodoItemRenderer.mxml
@@ -59,7 +59,7 @@ limitations under the License.
             public function removeItemClickHandler(event:MouseEvent):void {
                 COMPILE::JS
                 {
-                window.removeEventListener('click', commitLabelChanges, false);
+                document.removeEventListener('click', commitLabelChanges, 
true);
                 }
                 dispatchEvent(new TodoEvent(TodoEvent.ITEM_REMOVED, item));
             }
@@ -83,19 +83,19 @@ limitations under the License.
 
                 COMPILE::JS
                 {
-                window.addEventListener('click', commitLabelChanges, false);
+                document.addEventListener('click', commitLabelChanges, true);
                 }
             }
 
             /**
-             *  remove window listener to stop listening click events. If user 
made changes to label, commit 
+             *  remove document listener to stop listening click events. If 
user made changes to label, commit 
              *  changes to the todo item and exit 'editing' state.
              *  Make destroy button visible if mouse is over renderer.
              */
             public function commitLabelChanges():void {
                 COMPILE::JS
                 {
-                window.removeEventListener('click', commitLabelChanges, false);
+                document.removeEventListener('click', commitLabelChanges, 
true);
                 }
                 if(item.label != editfield.text)
                     dispatchEvent(new TodoEvent(TodoEvent.ITEM_LABEL_CHANGED, 
item, editfield.text));
@@ -144,7 +144,8 @@ limitations under the License.
         text="{item ? item.label : ''}" multiline="true"
         visible.normal="true" visible.editing="false"
         className="{item ? (item.done ? 'todolabel completed' : 'todolabel') : 
'todolabel' }"
-        doubleClick="goToEditMode(event)"/>
+        doubleClick="goToEditMode(event)"
+        />
 
     <j:TextInput localId="editfield" width="100%"
         visible.normal="false" visible.editing="true"