This is an automated email from the ASF dual-hosted git repository.
carlosrovira pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/royale-asjs.git
The following commit(s) were added to refs/heads/develop by this push:
new 277ac4f jewel-itemrenderer: default rowHeight to 34px (as
$item-min-height in sass), and return to flex layout now that we have more
control of rowCount/rowHeight
277ac4f is described below
commit 277ac4f394f8700f6b81b3a00810df598f37585a
Author: Carlos Rovira <[email protected]>
AuthorDate: Sat Feb 8 10:33:07 2020 +0100
jewel-itemrenderer: default rowHeight to 34px (as $item-min-height in
sass), and return to flex layout now that we have more control of
rowCount/rowHeight
---
frameworks/projects/Jewel/src/main/resources/defaults.css | 3 ++-
.../org/apache/royale/jewel/beads/models/ListPresentationModel.as | 2 +-
frameworks/projects/Jewel/src/main/sass/components/_itemRenderer.sass | 3 ++-
3 files changed, 5 insertions(+), 3 deletions(-)
diff --git a/frameworks/projects/Jewel/src/main/resources/defaults.css
b/frameworks/projects/Jewel/src/main/resources/defaults.css
index 62c7628..5d33c43 100644
--- a/frameworks/projects/Jewel/src/main/resources/defaults.css
+++ b/frameworks/projects/Jewel/src/main/resources/defaults.css
@@ -940,13 +940,14 @@ j|ImageButton {
}
.jewel.item, .jewel.navigationlink, .jewel.tabbarbutton {
- display: block;
+ display: flex;
min-height: 34px;
text-decoration: none;
letter-spacing: 0;
line-height: normal !important;
overflow: hidden;
cursor: auto;
+ align-items: center;
}
.jewel.item.mxmlContent, .jewel.navigationlink.mxmlContent,
.jewel.tabbarbutton.mxmlContent {
display: flex;
diff --git
a/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/beads/models/ListPresentationModel.as
b/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/beads/models/ListPresentationModel.as
index 8dea380..fb40281 100644
---
a/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/beads/models/ListPresentationModel.as
+++
b/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/beads/models/ListPresentationModel.as
@@ -47,7 +47,7 @@ package org.apache.royale.jewel.beads.models
super();
}
- private var _rowHeight:Number = 30;
+ private var _rowHeight:Number = 34;
/**
* The height of each row.
*
diff --git
a/frameworks/projects/Jewel/src/main/sass/components/_itemRenderer.sass
b/frameworks/projects/Jewel/src/main/sass/components/_itemRenderer.sass
index 3bd361d..32b8054 100644
--- a/frameworks/projects/Jewel/src/main/sass/components/_itemRenderer.sass
+++ b/frameworks/projects/Jewel/src/main/sass/components/_itemRenderer.sass
@@ -23,13 +23,14 @@
$item-min-height: 34px
.jewel.item, .jewel.navigationlink, .jewel.tabbarbutton
- display: block // this works better when render is just text
+ display: flex
min-height: $item-min-height
text-decoration: none
letter-spacing: 0
line-height: normal !important
overflow: hidden
cursor: auto
+ align-items: center
// pointer-events: none
// used when the renderer is extended, so we change to flex display
