[royale-asjs] branch develop updated: virtual-layout: fix an issue in Jewel where going directly to first item with scrollbar thumb will not show the last visible itemrenderer. Others should check Basic version since could have the same issue, but can't ensure since measure is done slightly different.

[carlosrovira]

This is an automated email from the ASF dual-hosted git repository.

carlosrovira pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/royale-asjs.git


The following commit(s) were added to refs/heads/develop by this push:
     new 216cf58  virtual-layout: fix an issue in Jewel where going directly to 
first item with scrollbar thumb will not show the last visible itemrenderer. 
Others should check Basic version since could have the same issue, but can't 
ensure since measure is done slightly different.
216cf58 is described below

commit 216cf58c1ed2df14e8caeae3fa71dc069927299a
Author: Carlos Rovira <carlosrov...@apache.org>
AuthorDate: Mon Feb 10 18:25:33 2020 +0100

    virtual-layout: fix an issue in Jewel where going directly to first item 
with scrollbar thumb will not show the last visible itemrenderer. Others should 
check Basic version since could have the same issue, but can't ensure since 
measure is done slightly different.
---
 .../apache/royale/jewel/beads/layouts/VirtualListVerticalLayout.as    | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git 
a/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/beads/layouts/VirtualListVerticalLayout.as
 
b/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/beads/layouts/VirtualListVerticalLayout.as
index 8682324..a22ca7a 100644
--- 
a/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/beads/layouts/VirtualListVerticalLayout.as
+++ 
b/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/beads/layouts/VirtualListVerticalLayout.as
@@ -285,7 +285,7 @@ package org.apache.royale.jewel.beads.layouts
                 var viewportHeight:Number = contentView.height;
                 var startIndex:int = Math.floor(viewportTop / 
presentationModel.rowHeight);
                 var factory:IDataProviderVirtualItemRendererMapper = 
host.getBeadByType(IDataProviderVirtualItemRendererMapper) as 
IDataProviderVirtualItemRendererMapper;
-                var endIndex:int = Math.ceil((viewportTop + viewportHeight) / 
presentationModel.rowHeight);
+                var endIndex:int = Math.ceil((viewportTop + viewportHeight) / 
presentationModel.rowHeight) + 1;
                 var freeIndex:int;
                 var firstIndex:int;
                 var lastIndex:int;
@@ -380,14 +380,12 @@ package org.apache.royale.jewel.beads.layouts
                     {
                     //    trace("i < firstIndex: creating: i = " + i);
                        ir  = factory.getItemRendererForIndex(i, i - startIndex 
+ 1);
-                    //    ir.element.style.display = "block";
                        visibleIndexes.push(i);
                     }
                     else if (i > lastIndex)
                     {
                         // trace("i > lastIndex: creating: i = " + i);
                         ir  = factory.getItemRendererForIndex(i, i - 
startIndex + 1);
-                        // ir.element.style.display = "block";
                         visibleIndexes.push(i);
                     }
                 }