[royale-asjs] branch develop updated: jewel-collection-mapper: fix assing null directly to dataProvider does not clear renderers

[carlosrovira]

This is an automated email from the ASF dual-hosted git repository.

carlosrovira pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/royale-asjs.git


The following commit(s) were added to refs/heads/develop by this push:
     new 5ffed6d  jewel-collection-mapper: fix assing null directly to 
dataProvider does not clear renderers
5ffed6d is described below

commit 5ffed6daad0668e4f63d31c2c79fe7a1fe0b6aa1
Author: Carlos Rovira <carlosrov...@apache.org>
AuthorDate: Fri Mar 6 13:32:45 2020 +0100

    jewel-collection-mapper: fix assing null directly to dataProvider does not 
clear renderers
---
 .../itemRenderers/DataItemRendererFactoryForCollectionView.as     | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git 
a/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/beads/itemRenderers/DataItemRendererFactoryForCollectionView.as
 
b/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/beads/itemRenderers/DataItemRendererFactoryForCollectionView.as
index 614c8e7..8afc1d3 100644
--- 
a/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/beads/itemRenderers/DataItemRendererFactoryForCollectionView.as
+++ 
b/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/beads/itemRenderers/DataItemRendererFactoryForCollectionView.as
@@ -36,6 +36,7 @@ package org.apache.royale.jewel.beads.itemRenderers
     import org.apache.royale.core.IOwnerViewItemRenderer;
        import 
org.apache.royale.jewel.supportClasses.list.IListPresentationModel;
        import org.apache.royale.utils.loadBeadFromValuesManager;
+       import org.apache.royale.utils.sendStrandEvent;
        
        /**
         * This class creates itemRenderer instances from the data contained 
within an ICollectionView
@@ -159,8 +160,6 @@ package org.apache.royale.jewel.beads.itemRenderers
                        if (!dataProviderModel)
                                return;
                        var dp:ICollectionView = dataProviderModel.dataProvider 
as ICollectionView;
-                       if (!dp)
-                               return;
                        
                        // remove this and better add beads when needed
                        // listen for individual items being added in the 
future.
@@ -170,6 +169,9 @@ package org.apache.royale.jewel.beads.itemRenderers
                        // dped.addEventListener(CollectionEvent.ITEM_UPDATED, 
itemUpdatedHandler);
                        
                        dataGroup.removeAllItemRenderers();
+
+                       if (!dp)
+                               return;
                        
                        var presentationModel:IListPresentationModel = 
_strand.getBeadByType(IListPresentationModel) as IListPresentationModel;
                        labelField = dataProviderModel.labelField;
@@ -182,7 +184,7 @@ package org.apache.royale.jewel.beads.itemRenderers
                                fillRenderer(i, item, ir, presentationModel);
                        }
                        
-                       IEventDispatcher(_strand).dispatchEvent(new 
Event("itemsCreated"));
+                       sendStrandEvent(_strand,"itemsCreated");
                }
                
                /**