This is an automated email from the ASF dual-hosted git repository.

carlosrovira pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/royale-asjs.git


The following commit(s) were added to refs/heads/develop by this push:
     new 61421fd  jewel: remove CollectionChangeUpdateForArrayList (the bead is 
now in Basic), update Tour De Jewel to use Basic version
61421fd is described below

commit 61421fdbb9204b019724df2c6b2eb678b021df60
Author: Carlos Rovira <[email protected]>
AuthorDate: Sat Apr 4 18:08:50 2020 +0200

    jewel: remove CollectionChangeUpdateForArrayList (the bead is now in 
Basic), update Tour De Jewel to use Basic version
---
 .../src/main/royale/AdvancedListPlayGround.mxml    |   6 +-
 .../Jewel/src/main/resources/jewel-manifest.xml    |   1 -
 .../CollectionChangeUpdateForArrayListData.as      | 153 ---------------------
 3 files changed, 3 insertions(+), 157 deletions(-)

diff --git 
a/examples/jewel/TourDeJewel/src/main/royale/AdvancedListPlayGround.mxml 
b/examples/jewel/TourDeJewel/src/main/royale/AdvancedListPlayGround.mxml
index 17d2475..e568f4d 100644
--- a/examples/jewel/TourDeJewel/src/main/royale/AdvancedListPlayGround.mxml
+++ b/examples/jewel/TourDeJewel/src/main/royale/AdvancedListPlayGround.mxml
@@ -198,7 +198,7 @@ limitations under the License.
                                                                
change="onChange(event)">
                                                        <j:beads>
                                                                
<j:RemoveAllItemRendererForArrayListData/>
-                                                               
<j:CollectionChangeUpdateForArrayListData/>
+                                                               
<js:CollectionChangeUpdateForArrayListData/>
                                                        </j:beads>
                                                </j:List>
                                                <j:Label text="item count: 
{ArrayListView(list1.dataProvider).length}"/>
@@ -211,7 +211,7 @@ limitations under the License.
                                                                
change="onChange(event)">
                                                        <j:beads>
                                                                
<j:RemoveAllItemRendererForArrayListData/>
-                                                               
<j:CollectionChangeUpdateForArrayListData/>
+                                                               
<js:CollectionChangeUpdateForArrayListData/>
                                                        </j:beads>
                                                </j:List>
                                                <j:Label text="item count: 
{ArrayListView(list2.dataProvider).length}"/>
@@ -224,7 +224,7 @@ limitations under the License.
                                                                
change="onChange(event)">
                                                        <j:beads>
                                                                
<j:RemoveAllItemRendererForArrayListData/>
-                                                               
<j:CollectionChangeUpdateForArrayListData/>
+                                                               
<js:CollectionChangeUpdateForArrayListData/>
                                                        </j:beads>
                                                </j:List>
                                                <j:Label text="item count: 
{ArrayListView(list3.dataProvider).length}"/>
diff --git a/frameworks/projects/Jewel/src/main/resources/jewel-manifest.xml 
b/frameworks/projects/Jewel/src/main/resources/jewel-manifest.xml
index 86c91d3..1e4697f 100644
--- a/frameworks/projects/Jewel/src/main/resources/jewel-manifest.xml
+++ b/frameworks/projects/Jewel/src/main/resources/jewel-manifest.xml
@@ -230,7 +230,6 @@
     <component id="AddListItemRendererForArrayListData" 
class="org.apache.royale.jewel.beads.itemRenderers.AddListItemRendererForArrayListData"
 />
     <component id="RemoveListItemRendererForArrayListData" 
class="org.apache.royale.jewel.beads.itemRenderers.RemoveListItemRendererForArrayListData"
 />
     <component id="UpdateListItemRendererForArrayListData" 
class="org.apache.royale.jewel.beads.itemRenderers.UpdateListItemRendererForArrayListData"
 />
-    <component id="CollectionChangeUpdateForArrayListData" 
class="org.apache.royale.jewel.beads.itemRenderers.CollectionChangeUpdateForArrayListData"
 />
     
     <component id="AddDataGridItemRendererForArrayListData" 
class="org.apache.royale.jewel.beads.itemRenderers.AddDataGridItemRendererForArrayListData"
 />
     <component id="RemoveDataGridItemRendererForArrayListData" 
class="org.apache.royale.jewel.beads.itemRenderers.RemoveDataGridItemRendererForArrayListData"
 />
diff --git 
a/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/beads/itemRenderers/CollectionChangeUpdateForArrayListData.as
 
b/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/beads/itemRenderers/CollectionChangeUpdateForArrayListData.as
deleted file mode 100644
index 62e4658..0000000
--- 
a/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/beads/itemRenderers/CollectionChangeUpdateForArrayListData.as
+++ /dev/null
@@ -1,153 +0,0 @@
-////////////////////////////////////////////////////////////////////////////////
-//
-//  Licensed to the Apache Software Foundation (ASF) under one or more
-//  contributor license agreements.  See the NOTICE file distributed with
-//  this work for additional information regarding copyright ownership.
-//  The ASF licenses this file to You under the Apache License, Version 2.0
-//  (the "License"); you may not use this file except in compliance with
-//  the License.  You may obtain a copy of the License at
-//
-//      http://www.apache.org/licenses/LICENSE-2.0
-//
-//  Unless required by applicable law or agreed to in writing, software
-//  distributed under the License is distributed on an "AS IS" BASIS,
-//  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-//  See the License for the specific language governing permissions and
-//  limitations under the License.
-//
-////////////////////////////////////////////////////////////////////////////////
-package org.apache.royale.jewel.beads.itemRenderers
-{
-       import org.apache.royale.core.IBead;
-       import org.apache.royale.core.IDataProviderModel;
-       import org.apache.royale.core.ISelectionModel;
-       import org.apache.royale.core.IStrand;
-       import org.apache.royale.events.CollectionEvent;
-       import org.apache.royale.events.Event;
-       import org.apache.royale.events.IEventDispatcher;
-
-
-    /**
-        *  Handles the update of an itemRenderer in a List component once the 
corresponding
-        *  datum has been updated from the IDataProviderModel.
-        *
-        *  @langversion 3.0
-        *  @playerversion Flash 10.2
-        *  @playerversion AIR 2.6
-        *  @productversion Royale 0.9.4
-        */
-       public class CollectionChangeUpdateForArrayListData implements IBead
-       {
-               /**
-                *  Constructor
-                *
-                *  @langversion 3.0
-                *  @playerversion Flash 10.2
-                *  @playerversion AIR 2.6
-                *  @productversion Royale 0.9.4
-                */
-               public function CollectionChangeUpdateForArrayListData()
-               {
-               }
-
-               protected var _strand:IStrand;
-
-        protected var labelField:String;
-
-               /**
-                *  @copy org.apache.royale.core.IStrand
-                *
-                *  @langversion 3.0
-                *  @playerversion Flash 10.2
-                *  @playerversion AIR 2.6
-                *  @productversion Royale 0.9.4
-                *  @royaleignorecoercion 
org.apache.royale.events.IEventDispatcher
-                */
-               public function set strand(value:IStrand):void
-               {
-                       _strand = value;
-                       
IEventDispatcher(value).addEventListener("initComplete", initComplete);
-               }
-
-               /**
-                *  finish setup
-                *
-                *  @langversion 3.0
-                *  @playerversion Flash 10.2
-                *  @playerversion AIR 2.6
-                *  @productversion Royale 0.9.4
-                *  @royaleignorecoercion 
org.apache.royale.events.IEventDispatcher
-                */
-               protected function initComplete(event:Event):void
-               {
-                       
IEventDispatcher(_strand).removeEventListener("initComplete", initComplete);
-
-                       _dataProviderModel = 
_strand.getBeadByType(ISelectionModel) as ISelectionModel;
-                       labelField = _dataProviderModel.labelField;
-
-                       
dataProviderModel.addEventListener("dataProviderChanged", 
dataProviderChangeHandler);
-
-                       // invoke now in case "dataProviderChanged" has already 
been dispatched.
-                       dataProviderChangeHandler(null);
-               }
-
-               private var dp:IEventDispatcher;
-               private var ignoreDPChange:Boolean;
-               /**
-                * @private
-                * @royaleignorecoercion 
org.apache.royale.events.IEventDispatcher
-                */
-               protected function dataProviderChangeHandler(event:Event):void
-               {
-                       if (ignoreDPChange) return;
-                       if(dp)
-                       {
-                               
dp.removeEventListener(CollectionEvent.COLLECTION_CHANGED, 
handleCollectionChanged);
-                       }
-                       dp = dataProviderModel.dataProvider as IEventDispatcher;
-                       if (!dp)
-                               return;
-
-                       // listen for COLLECTION_CHANGED in the future.
-                       dp.addEventListener(CollectionEvent.COLLECTION_CHANGED, 
handleCollectionChanged);
-               }
-
-               /**
-                *  Handles the COLLECTION_CHANGED event by refreshing the full 
set of renderers.
-                *
-                *  @langversion 3.0
-                *  @playerversion Flash 10.2
-                *  @playerversion AIR 2.6
-                *  @productversion Royale 0.9.4
-                *  @royaleignorecoercion 
org.apache.royale.events.IEventDispatcher
-         *  @royaleignorecoercion org.apache.royale.core.ISelectionModel
-                */
-               protected function 
handleCollectionChanged(event:CollectionEvent):void
-               {
-                       ignoreDPChange = true;
-                       //simulate a dataProvider change (full renderer refresh)
-                       _dataProviderModel.dispatchEvent(new 
Event('dataProviderChanged'));
-                       ignoreDPChange = false;
-               }
-
-               private var _dataProviderModel:IDataProviderModel;
-
-               /**
-                *  The org.apache.royale.core.IDataProviderModel that contains 
the
-                *  data source.
-                *
-                *  @langversion 3.0
-                *  @playerversion Flash 10.2
-                *  @playerversion AIR 2.6
-                *  @productversion Royale 0.9.4
-                */
-               public function get dataProviderModel():IDataProviderModel
-               {
-                       if (_dataProviderModel == null) {
-                               _dataProviderModel = 
_strand.getBeadByType(IDataProviderModel) as IDataProviderModel;
-                       }
-                       return _dataProviderModel;
-               }
-               
-       }
-}

Reply via email to