[royale-asjs] branch develop updated: jewel-ListKeyDownController: make IRemovableBead

[carlosrovira]

This is an automated email from the ASF dual-hosted git repository.

carlosrovira pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/royale-asjs.git


The following commit(s) were added to refs/heads/develop by this push:
     new b4de72b  jewel-ListKeyDownController: make IRemovableBead
b4de72b is described below

commit b4de72b486fc396adaae637ace7b8822ed235309
Author: Carlos Rovira <carlosrov...@apache.org>
AuthorDate: Fri Apr 24 20:27:44 2020 +0200

    jewel-ListKeyDownController: make IRemovableBead
---
 .../beads/controllers/ListKeyDownController.as     | 24 ++++++++++++++++------
 1 file changed, 18 insertions(+), 6 deletions(-)

diff --git 
a/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/beads/controllers/ListKeyDownController.as
 
b/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/beads/controllers/ListKeyDownController.as
index 50a306b..5feefe7 100644
--- 
a/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/beads/controllers/ListKeyDownController.as
+++ 
b/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/beads/controllers/ListKeyDownController.as
@@ -21,8 +21,10 @@ package org.apache.royale.jewel.beads.controllers
        import org.apache.royale.core.Bead;
        import org.apache.royale.core.IBeadKeyController;
        import org.apache.royale.core.IFocusable;
+       import org.apache.royale.core.IRemovableBead;
        import org.apache.royale.core.ISelectionModel;
        import org.apache.royale.core.IStrand;
+       import org.apache.royale.events.IEventDispatcher;
        import org.apache.royale.events.KeyboardEvent;
        import org.apache.royale.html.beads.IListView;
        import org.apache.royale.jewel.beads.views.IScrollToIndexView;
@@ -46,7 +48,7 @@ package org.apache.royale.jewel.beads.controllers
      *  @playerversion AIR 2.6
      *  @productversion Royale 0.9.7
      */
-       public class ListKeyDownController extends Bead implements 
IBeadKeyController
+       public class ListKeyDownController extends Bead implements 
IBeadKeyController, IRemovableBead
        {
         /**
          *  Constructor.
@@ -101,6 +103,19 @@ package org.apache.royale.jewel.beads.controllers
             listenOnStrand(KeyboardEvent.KEY_DOWN, keyEventHandler);
                }
 
+               /**
+                *  The actions needed before the removal
+                *
+                *  @langversion 3.0
+                *  @playerversion Flash 10.2
+                *  @playerversion AIR 2.6
+                *  @productversion Royale 0.9.8
+                */
+               public function tearDown():void
+               {
+                       
IEventDispatcher(_strand).removeEventListener(KeyboardEvent.KEY_DOWN, 
keyEventHandler);
+               }
+
         /**
                 * @private
                 */
@@ -129,11 +144,8 @@ package org.apache.royale.jewel.beads.controllers
                                listModel.selectedItem = 
listModel.dataProvider.getItemAt(listModel.selectedIndex);
 
                                var ir:IFocusable = 
listView.dataGroup.getItemRendererForIndex(listModel.selectedIndex) as 
IFocusable;
-                               if(ir)
-                                       ir.setFocus();
-                               else
-                                       trace("!! " + listModel.selectedIndex);
-
+                               ir.setFocus();
+                               
                 (listView as IScrollToIndexView).scrollToIndex(index);
                                
                                sendEvent(listView.host, 'change');