This is an automated email from the ASF dual-hosted git repository.

carlosrovira pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/royale-asjs.git


The following commit(s) were added to refs/heads/develop by this push:
     new 2e0673b  jewel-CollapsibleNavigationSectionRenderer: solve "change" in 
no-submenu items, and fix duplicate "change" in sub menu items
2e0673b is described below

commit 2e0673ba215266f9e12bcf271859e6bcc0187e84
Author: Carlos Rovira <[email protected]>
AuthorDate: Sun May 17 12:20:13 2020 +0200

    jewel-CollapsibleNavigationSectionRenderer: solve "change" in no-submenu 
items, and fix duplicate "change" in sub menu items
---
 .../itemRenderers/CollapsibleNavigationSectionRenderer.as      | 10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)

diff --git 
a/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/itemRenderers/CollapsibleNavigationSectionRenderer.as
 
b/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/itemRenderers/CollapsibleNavigationSectionRenderer.as
index b203992..7032c06 100644
--- 
a/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/itemRenderers/CollapsibleNavigationSectionRenderer.as
+++ 
b/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/itemRenderers/CollapsibleNavigationSectionRenderer.as
@@ -75,7 +75,12 @@ package org.apache.royale.jewel.itemRenderers
 
                        // this check should be smarter, check sectionNavItem 
and its childs
                        if (event.target == sectionNavItem || 
event.target.parent == sectionNavItem || event.target.parent.parent == 
sectionNavItem) {
-                               event.stopImmediatePropagation();
+                               if(children != null) {
+                                       event.stopImmediatePropagation();
+                               } else {
+                                       // avoid change event 2 times
+                                       return;
+                               }
                                navTarget = this;
                                //make 'this' the event.target
                                dispatchEvent(new Event('sectionClick'));
@@ -85,6 +90,9 @@ package org.apache.royale.jewel.itemRenderers
                                        navTarget.hovered = true;
                                }
                        }
+
+                       // avoid double change in submenu items
+                       event.stopImmediatePropagation();
                }
                
                public function getSelectedSubmenuItem():Object {

Reply via email to