This is an automated email from the ASF dual-hosted git repository.
carlosrovira pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/royale-asjs.git
The following commit(s) were added to refs/heads/develop by this push:
new 3e663c8 jewel-table: fix tableitems height when content is small or
there's no content and initializers not beign used when render is cutomized per
column
3e663c8 is described below
commit 3e663c869b1066e60820b371d7a51edc88bf8f5b
Author: Carlos Rovira <[email protected]>
AuthorDate: Wed Jul 1 18:42:51 2020 +0200
jewel-table: fix tableitems height when content is small or there's no
content and initializers not beign used when render is cutomized per column
---
.../beads/itemRenderers/TableItemRendererFactoryForCollectionView.as | 2 +-
frameworks/themes/JewelTheme/src/main/resources/defaults.css | 3 +++
.../themes/JewelTheme/src/main/sass/components-primary/_table.sass | 1 +
3 files changed, 5 insertions(+), 1 deletion(-)
diff --git
a/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/beads/itemRenderers/TableItemRendererFactoryForCollectionView.as
b/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/beads/itemRenderers/TableItemRendererFactoryForCollectionView.as
index 88c4960..e0a51d5 100644
---
a/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/beads/itemRenderers/TableItemRendererFactoryForCollectionView.as
+++
b/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/beads/itemRenderers/TableItemRendererFactoryForCollectionView.as
@@ -211,6 +211,7 @@ package org.apache.royale.jewel.beads.itemRenderers
(ir as StyledDataItemRenderer).dataField = labelField;
(ir as StyledDataItemRenderer).rowIndex
= i;
(ir as
StyledDataItemRenderer).columnIndex = j;
+ (itemRendererInitializer as
IIndexedItemRendererInitializer).initializeIndexedItemRenderer(ir, item, index);
fillRenderer(index++, item, (ir as IIndexedItemRenderer),
presentationModel);
if(column.align != "")
@@ -245,7 +246,6 @@ package org.apache.royale.jewel.beads.itemRenderers
itemRenderer:IIndexedItemRenderer,
presentationModel:IListPresentationModel):void
{
- (itemRendererInitializer as
IIndexedItemRendererInitializer).initializeIndexedItemRenderer(itemRenderer,
item, index);
tbody.addItemRendererAt(itemRenderer, index);
(itemRenderer as ILabelFieldItemRenderer).labelField =
labelField;
diff --git a/frameworks/themes/JewelTheme/src/main/resources/defaults.css
b/frameworks/themes/JewelTheme/src/main/resources/defaults.css
index 132a957..7d39eb0 100644
--- a/frameworks/themes/JewelTheme/src/main/resources/defaults.css
+++ b/frameworks/themes/JewelTheme/src/main/resources/defaults.css
@@ -1254,6 +1254,9 @@ j|FormItem {
box-shadow: inset 0 1px 0 white;
}
+.jewel.tableitem {
+ height: 100%;
+}
.jewel.tableitem.hovered {
color: #FFFFFF;
background: #3CADF1;
diff --git
a/frameworks/themes/JewelTheme/src/main/sass/components-primary/_table.sass
b/frameworks/themes/JewelTheme/src/main/sass/components-primary/_table.sass
index 3ecfa5c..e664fc9 100644
--- a/frameworks/themes/JewelTheme/src/main/sass/components-primary/_table.sass
+++ b/frameworks/themes/JewelTheme/src/main/sass/components-primary/_table.sass
@@ -138,6 +138,7 @@ $table-border-radius: $border-radius
// border: 1px solid black
.jewel.tableitem
+ height: 100%
&.hovered
color: $font-theme-color