[royale-asjs] branch develop updated: jewel-searchfilter-beads:some little improvements in code

[carlosrovira]

This is an automated email from the ASF dual-hosted git repository.

carlosrovira pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/royale-asjs.git


The following commit(s) were added to refs/heads/develop by this push:
     new 30b9cd7  jewel-searchfilter-beads:some little improvements in code
30b9cd7 is described below

commit 30b9cd75f5f55eece11c7221605872904625acaa
Author: Carlos Rovira <carlos.rov...@apache.org>
AuthorDate: Mon Oct 5 23:45:52 2020 +0200

    jewel-searchfilter-beads:some little improvements in code
---
 .../apache/royale/jewel/beads/controls/combobox/SearchFilter.as    | 7 +++----
 .../royale/jewel/beads/controls/textinput/SearchFilterForList.as   | 6 +++---
 2 files changed, 6 insertions(+), 7 deletions(-)

diff --git 
a/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/beads/controls/combobox/SearchFilter.as
 
b/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/beads/controls/combobox/SearchFilter.as
index a71db61..7412797 100644
--- 
a/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/beads/controls/combobox/SearchFilter.as
+++ 
b/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/beads/controls/combobox/SearchFilter.as
@@ -19,7 +19,6 @@
 package org.apache.royale.jewel.beads.controls.combobox
 {
        import org.apache.royale.events.Event;
-       import org.apache.royale.events.IEventDispatcher;
        import org.apache.royale.jewel.beads.controls.combobox.IComboBoxView;
        import 
org.apache.royale.jewel.beads.controls.textinput.SearchFilterForList;
        import org.apache.royale.jewel.beads.views.ComboBoxView;
@@ -83,9 +82,9 @@ package org.apache.royale.jewel.beads.controls.combobox
                }
 
                override protected function onBeadsAdded(event:Event):void{
-                       
IEventDispatcher(_strand).addEventListener('dismissPopUp', removeListListeners);
-                       
IEventDispatcher(_strand).addEventListener('popUpOpened', popUpOpenedHandler);
-                       
IEventDispatcher(_strand).addEventListener('popUpClosed', popUpClosedHandler);
+                       listenOnStrand('dismissPopUp', removeListListeners);
+                       listenOnStrand('popUpOpened', popUpOpenedHandler);
+                       listenOnStrand('popUpClosed', popUpClosedHandler);
 
                        comboView = event.target.view as IComboBoxView;
             if (comboView)
diff --git 
a/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/beads/controls/textinput/SearchFilterForList.as
 
b/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/beads/controls/textinput/SearchFilterForList.as
index 9b5a2d6..58febc0 100644
--- 
a/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/beads/controls/textinput/SearchFilterForList.as
+++ 
b/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/beads/controls/textinput/SearchFilterForList.as
@@ -26,6 +26,8 @@ package org.apache.royale.jewel.beads.controls.textinput
        import org.apache.royale.core.IStrand;
        import org.apache.royale.events.Event;
        import org.apache.royale.events.KeyboardEvent;
+       import org.apache.royale.events.utils.NavigationKeys;
+       import org.apache.royale.events.utils.WhitespaceKeys;
        import org.apache.royale.html.beads.IListView;
        import org.apache.royale.html.util.getLabelFromData;
        import org.apache.royale.jewel.List;
@@ -34,8 +36,6 @@ package org.apache.royale.jewel.beads.controls.textinput
        import 
org.apache.royale.jewel.supportClasses.list.IListPresentationModel;
        import org.apache.royale.jewel.supportClasses.textinput.TextInputBase;
        import org.apache.royale.utils.sendEvent;
-       import org.apache.royale.events.utils.WhitespaceKeys;
-       import org.apache.royale.events.utils.NavigationKeys;
 
        /**
         *  The SearchFilterForList bead class is a specialty bead that can be 
used with
@@ -182,7 +182,7 @@ package org.apache.royale.jewel.beads.controls.textinput
                        {
                                var rowHeight:Number;
                                // all items renderers with same height
-                               rowHeight = isNaN(pm.rowHeight) ? 
ListPresentationModel.DEFAULT_ROW_HEIGHT : rowHeight;
+                               rowHeight = isNaN(pm.rowHeight) ? 
ListPresentationModel.DEFAULT_ROW_HEIGHT : pm.rowHeight;
                                totalHeight = _visibleIndexes.length * 
rowHeight - scrollArea.clientHeight;
                                
                                scrollArea.scrollTop = Math.min(index * 
rowHeight, totalHeight);