[royale-compiler] branch develop updated: AccessorDefinition: fix null exception in hasConflictingLanguageNSDefinition() when accessor is created by [Bindable] variable

[joshtynjala]

This is an automated email from the ASF dual-hosted git repository.

joshtynjala pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/royale-compiler.git


The following commit(s) were added to refs/heads/develop by this push:
     new 062da91  AccessorDefinition: fix null exception in 
hasConflictingLanguageNSDefinition() when accessor is created by [Bindable] 
variable
062da91 is described below

commit 062da914d93c4f0f2ee75a3523000d91c0240e30
Author: Josh Tynjala <joshtynj...@apache.org>
AuthorDate: Wed Oct 14 11:10:48 2020 -0700

    AccessorDefinition: fix null exception in 
hasConflictingLanguageNSDefinition() when accessor is created by [Bindable] 
variable
    
    The code assumed that getFunctionNode() would be non-null, but bindable 
variables won't have a function node. Switched to getNode() instead.
---
 .../apache/royale/compiler/internal/definitions/AccessorDefinition.java | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git 
a/compiler/src/main/java/org/apache/royale/compiler/internal/definitions/AccessorDefinition.java
 
b/compiler/src/main/java/org/apache/royale/compiler/internal/definitions/AccessorDefinition.java
index e47d4e8..f842087 100644
--- 
a/compiler/src/main/java/org/apache/royale/compiler/internal/definitions/AccessorDefinition.java
+++ 
b/compiler/src/main/java/org/apache/royale/compiler/internal/definitions/AccessorDefinition.java
@@ -239,7 +239,7 @@ public abstract class AccessorDefinition extends 
FunctionDefinition implements I
                     ((AccessorDefinition) check).problematic = true;
                     //checking occurs twice, don't add multiple duplicate 
problems for the same check
                     problematic = true;
-                    project.getProblems().add(new 
DuplicateFunctionDefinitionProblem(getFunctionNode().getNameExpressionNode(), 
this.getBaseName()));
+                    project.getProblems().add(new 
DuplicateFunctionDefinitionProblem(getNode().getNameExpressionNode(), 
this.getBaseName()));
                 }
                 return true;
             }