[royale-compiler] 02/04: playerglobal-source-gen: better string detection on default parameter values

[joshtynjala]

This is an automated email from the ASF dual-hosted git repository.

joshtynjala pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/royale-compiler.git

commit 6e96c07ae38c76f633e82c15bdbf31749dfe4562
Author: Josh Tynjala <joshtynj...@apache.org>
AuthorDate: Wed Feb 17 14:45:50 2021 -0800

    playerglobal-source-gen: better string detection on default parameter values
---
 .../java/org/apache/royale/playerglobal/PlayerglobalSourceGen.java   | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git 
a/playerglobal-source-gen/src/main/java/org/apache/royale/playerglobal/PlayerglobalSourceGen.java
 
b/playerglobal-source-gen/src/main/java/org/apache/royale/playerglobal/PlayerglobalSourceGen.java
index dc0201a..9a95dee 100644
--- 
a/playerglobal-source-gen/src/main/java/org/apache/royale/playerglobal/PlayerglobalSourceGen.java
+++ 
b/playerglobal-source-gen/src/main/java/org/apache/royale/playerglobal/PlayerglobalSourceGen.java
@@ -859,8 +859,9 @@ class PlayerglobalSourceGen {
                if ("unknown".equals(paramValue)) {
                        paramValue = "null";
                }
-               boolean isString = ("String".equals(varType) || 
paramValue.matches("[A-Za-z]+")) && !"null".equals(paramValue)
-                               && !"NaN".equals(paramValue) && 
!"true".equals(paramValue) && !"false".equals(paramValue);
+               boolean isString = ("String".equals(varType) || 
paramValue.matches("[A-Za-z\\*]+"))
+                               && !"undefined".equals(paramValue) && 
!"null".equals(paramValue) && !"NaN".equals(paramValue)
+                               && !"true".equals(paramValue) && 
!"false".equals(paramValue);
                if (isString) {
                        builder.append("\"");
                }