(royale-asjs) branch develop updated: This optimization breaks node opening/closing

[harbs]

This is an automated email from the ASF dual-hosted git repository.

harbs pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/royale-asjs.git


The following commit(s) were added to refs/heads/develop by this push:
     new 942a6db9d1 This optimization breaks node opening/closing
942a6db9d1 is described below

commit 942a6db9d19a119e85bd2f454519f2f3f0f93ccb
Author: Harbs <ha...@in-tools.com>
AuthorDate: Thu Dec 21 13:30:03 2023 +0200

    This optimization breaks node opening/closing
---
 .../apache/royale/html/beads/TreeItemRendererInitializer.as  | 12 ------------
 1 file changed, 12 deletions(-)

diff --git 
a/frameworks/projects/Basic/src/main/royale/org/apache/royale/html/beads/TreeItemRendererInitializer.as
 
b/frameworks/projects/Basic/src/main/royale/org/apache/royale/html/beads/TreeItemRendererInitializer.as
index 5940193a5b..a7cdfa108f 100644
--- 
a/frameworks/projects/Basic/src/main/royale/org/apache/royale/html/beads/TreeItemRendererInitializer.as
+++ 
b/frameworks/projects/Basic/src/main/royale/org/apache/royale/html/beads/TreeItemRendererInitializer.as
@@ -64,18 +64,6 @@ package org.apache.royale.html.beads
                {
                        if (!dataProviderModel)
                                return;
-                       /**
-                        * For the vast majority of cases,
-                        * there is no need to reinitialize the whole item 
renderer on an update.
-                        * Just updating the index and nothing else can save a 
lot of computation.
-                        * This is especially true for calculating node depth 
which can be expensive
-                        * for large data sets where the calculation is not 
optimized in subclasses.
-                        */
-                       if(ir.data == data)
-                       {
-                               ir.index = index;
-                               return;
-                       }
                        
                        super.initializeIndexedItemRenderer(ir, data, index);