This is an automated email from the ASF dual-hosted git repository.
joshtynjala pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/royale-compiler.git
The following commit(s) were added to refs/heads/develop by this push:
new 5d3b3f083 IdentifierNode: fix issue where asc can't compile because of
dependency on RoyaleProject (closes #242)
5d3b3f083 is described below
commit 5d3b3f083c5ad549eebb5e5ef02d174fa511f189
Author: Josh Tynjala <[email protected]>
AuthorDate: Tue Jan 13 09:36:40 2026 -0800
IdentifierNode: fix issue where asc can't compile because of dependency on
RoyaleProject (closes #242)
---
.../java/org/apache/royale/compiler/projects/ICompilerProject.java | 5 +++++
.../apache/royale/compiler/internal/parsing/as/ConfigProcessor.java | 6 ++++++
.../org/apache/royale/compiler/internal/projects/ASCProject.java | 6 ++++++
.../org/apache/royale/compiler/internal/projects/RoyaleProject.java | 1 +
.../org/apache/royale/compiler/internal/tree/as/IdentifierNode.java | 2 +-
5 files changed, 19 insertions(+), 1 deletion(-)
diff --git
a/compiler-common/src/main/java/org/apache/royale/compiler/projects/ICompilerProject.java
b/compiler-common/src/main/java/org/apache/royale/compiler/projects/ICompilerProject.java
index c4b8a5168..bc6797d1c 100644
---
a/compiler-common/src/main/java/org/apache/royale/compiler/projects/ICompilerProject.java
+++
b/compiler-common/src/main/java/org/apache/royale/compiler/projects/ICompilerProject.java
@@ -306,5 +306,10 @@ public interface ICompilerProject
* @return True if type inference is enabled.
*/
boolean getInferTypes();
+
+ /**
+ * @return True if strict XML is enabled.
+ */
+ boolean useStrictXML();
}
diff --git
a/compiler/src/main/java/org/apache/royale/compiler/internal/parsing/as/ConfigProcessor.java
b/compiler/src/main/java/org/apache/royale/compiler/internal/parsing/as/ConfigProcessor.java
index c13f48d90..f151ea7da 100644
---
a/compiler/src/main/java/org/apache/royale/compiler/internal/parsing/as/ConfigProcessor.java
+++
b/compiler/src/main/java/org/apache/royale/compiler/internal/parsing/as/ConfigProcessor.java
@@ -206,6 +206,12 @@ public class ConfigProcessor
// TODO Auto-generated method stub
return false;
}
+
+ @Override
+ public boolean useStrictXML() {
+ // TODO Auto-generated method stub
+ return false;
+ }
}
/**
diff --git
a/compiler/src/main/java/org/apache/royale/compiler/internal/projects/ASCProject.java
b/compiler/src/main/java/org/apache/royale/compiler/internal/projects/ASCProject.java
index 2b56ade64..b99831042 100644
---
a/compiler/src/main/java/org/apache/royale/compiler/internal/projects/ASCProject.java
+++
b/compiler/src/main/java/org/apache/royale/compiler/internal/projects/ASCProject.java
@@ -128,4 +128,10 @@ public class ASCProject extends CompilerProject implements
IASCProject
// TODO Auto-generated method stub
return false;
}
+
+ @Override
+ public boolean useStrictXML() {
+ // TODO Auto-generated method stub
+ return false;
+ }
}
diff --git
a/compiler/src/main/java/org/apache/royale/compiler/internal/projects/RoyaleProject.java
b/compiler/src/main/java/org/apache/royale/compiler/internal/projects/RoyaleProject.java
index dd3428603..4dd44aecf 100644
---
a/compiler/src/main/java/org/apache/royale/compiler/internal/projects/RoyaleProject.java
+++
b/compiler/src/main/java/org/apache/royale/compiler/internal/projects/RoyaleProject.java
@@ -2259,6 +2259,7 @@ public class RoyaleProject extends ASProject implements
IRoyaleProject, ICompile
return null;
}
+ @Override
public boolean useStrictXML()
{
return this.strictXML;
diff --git
a/compiler/src/main/java/org/apache/royale/compiler/internal/tree/as/IdentifierNode.java
b/compiler/src/main/java/org/apache/royale/compiler/internal/tree/as/IdentifierNode.java
index f96da286f..df434c321 100644
---
a/compiler/src/main/java/org/apache/royale/compiler/internal/tree/as/IdentifierNode.java
+++
b/compiler/src/main/java/org/apache/royale/compiler/internal/tree/as/IdentifierNode.java
@@ -896,7 +896,7 @@ public class IdentifierNode extends ExpressionNodeBase
implements IIdentifierNod
// and x is type XML you would get a
can't-convert-Object-to-String
// problem, but there is lots of existing source code that
expects
// this to compile with no cast.
- if (!((RoyaleProject)project).useStrictXML() &&
SemanticUtils.isXMLish(baseType, project))
+ if (!project.useStrictXML() &&
SemanticUtils.isXMLish(baseType, project))
return null;
if (baseExpr instanceof IdentifierNode)