[Passed]: EdgeTest, GraphConstructionTest, VertexPropertyTest, PropertyTest.


Project: http://git-wip-us.apache.org/repos/asf/incubator-s2graph/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-s2graph/commit/c508def0
Tree: http://git-wip-us.apache.org/repos/asf/incubator-s2graph/tree/c508def0
Diff: http://git-wip-us.apache.org/repos/asf/incubator-s2graph/diff/c508def0

Branch: refs/heads/master
Commit: c508def0ebaf79ed6a7f6507117bfca63c0b02e2
Parents: cbcb46c
Author: DO YUNG YOON <[email protected]>
Authored: Fri Apr 14 11:45:16 2017 +0900
Committer: DO YUNG YOON <[email protected]>
Committed: Fri Apr 14 11:45:16 2017 +0900

----------------------------------------------------------------------
 .../scala/org/apache/s2graph/core/S2Edge.scala  |  2 +-
 .../scala/org/apache/s2graph/core/S2Graph.scala | 90 +++++++++++++-------
 .../core/tinkerpop/S2GraphProvider.scala        |  2 +-
 3 files changed, 63 insertions(+), 31 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/incubator-s2graph/blob/c508def0/s2core/src/main/scala/org/apache/s2graph/core/S2Edge.scala
----------------------------------------------------------------------
diff --git a/s2core/src/main/scala/org/apache/s2graph/core/S2Edge.scala 
b/s2core/src/main/scala/org/apache/s2graph/core/S2Edge.scala
index 6321dd5..3b000f6 100644
--- a/s2core/src/main/scala/org/apache/s2graph/core/S2Edge.scala
+++ b/s2core/src/main/scala/org/apache/s2graph/core/S2Edge.scala
@@ -682,7 +682,7 @@ case class S2Edge(innerGraph: S2Graph,
 
   override def id(): AnyRef = {
     // NOTE: xxxForVertex makes direction to be "out"
-    val timestamp = if (this.innerLabel.consistencyLevel == "string") 0l else 
ts
+    val timestamp = if (this.innerLabel.consistencyLevel == "strong") 0l else 
ts
     EdgeId(srcVertex.innerId, tgtVertex.innerId, label(), direction, timestamp)
   }
 

http://git-wip-us.apache.org/repos/asf/incubator-s2graph/blob/c508def0/s2core/src/main/scala/org/apache/s2graph/core/S2Graph.scala
----------------------------------------------------------------------
diff --git a/s2core/src/main/scala/org/apache/s2graph/core/S2Graph.scala 
b/s2core/src/main/scala/org/apache/s2graph/core/S2Graph.scala
index f1f00e7..49e2272 100644
--- a/s2core/src/main/scala/org/apache/s2graph/core/S2Graph.scala
+++ b/s2core/src/main/scala/org/apache/s2graph/core/S2Graph.scala
@@ -528,49 +528,81 @@ object S2Graph {
   }
 }
 
+//@Graph.OptIn(Graph.OptIn.SUITE_PROCESS_STANDARD)
+//@Graph.OptIn(Graph.OptIn.SUITE_PROCESS_COMPUTER)
+//@Graph.OptIn(Graph.OptIn.SUITE_GROOVY_PROCESS_STANDARD)
+//@Graph.OptIn(Graph.OptIn.SUITE_GROOVY_PROCESS_COMPUTER)
+//@Graph.OptIn(Graph.OptIn.SUITE_GROOVY_ENVIRONMENT)
 @Graph.OptIn(Graph.OptIn.SUITE_STRUCTURE_STANDARD)
 @Graph.OptOuts(value = Array(
-  // pass
-  new Graph.OptOut(test="org.apache.tinkerpop.gremlin.structure.EdgeTest", 
method="*", reason="no"),
-  new 
Graph.OptOut(test="org.apache.tinkerpop.gremlin.structure.GraphConstructionTest",
 method="*", reason="no"),
-  new Graph.OptOut(test="org.apache.tinkerpop.gremlin.structure.PropertyTest", 
method="*", reason="no"),
-  new 
Graph.OptOut(test="org.apache.tinkerpop.gremlin.structure.VertexPropertyTest", 
method="*", reason="no"),
+//  new Graph.OptOut(test="org.apache.tinkerpop.gremlin.structure.EdgeTest", 
method="*", reason="no"),
+//  // passed: all, failed: none
+//
+//  new 
Graph.OptOut(test="org.apache.tinkerpop.gremlin.structure.GraphConstructionTest",
 method="*", reason="no"),
+//  // passed: all, failed: none
+//
+//  new 
Graph.OptOut(test="org.apache.tinkerpop.gremlin.structure.PropertyTest", 
method="*", reason="no"),
+//  // passed: all, failed: none
+//
+//  new 
Graph.OptOut(test="org.apache.tinkerpop.gremlin.structure.VertexPropertyTest", 
method="*", reason="no"),
+//  // passed: all, failed: none
+
+  new 
Graph.OptOut(test="org.apache.tinkerpop.gremlin.structure.FeatureSupportTest", 
method="*", reason="no"),
+  // passed: , failed: shouldEnableFeatureOnEdgeIfNotEnabled, 
shouldEnableFeatureOnVertexIfNotEnabled, shouldSupportUserSuppliedIdsOfTypeAny
+
+  new Graph.OptOut(test="org.apache.tinkerpop.gremlin.structure.VertexTest", 
method="shouldHaveExceptionConsistencyWhenAssigningSameIdOnEdge", 
reason="S2Vertex.addEdge behave as upsert."),
+  // passed: , failed: shouldHaveExceptionConsistencyWhenAssigningSameIdOnEdge
+
+    new 
Graph.OptOut(test="org.apache.tinkerpop.gremlin.structure.util.detached.DetachedEdgeTest",
 method="*", reason="no"),
+  // passed: all, failed: shouldNotEvaluateToEqualDifferentId
+
+
   new 
Graph.OptOut(test="org.apache.tinkerpop.gremlin.structure.util.detached.DetachedVertexTest",
 method="*", reason="no"),
+  // passed: all, failed: none
+
+  new 
Graph.OptOut(test="org.apache.tinkerpop.gremlin.structure.util.detached.DetachedGraphTest",
 method="*", reason="no"),
+  // passed: all, failed: none,  all ignored
 
-  // not passed
-  new 
Graph.OptOut(test="org.apache.tinkerpop.gremlin.structure.FeatureSupportTest", 
method="*", reason="no"), // pass
+  new 
Graph.OptOut(test="org.apache.tinkerpop.gremlin.structure.util.detached.DetachedPropertyTest",
 method="*", reason="no"),
+  // passed: , failed: shouldNotBeEqualPropertiesAsThereIsDifferentKey
 
-  new Graph.OptOut(test="org.apache.tinkerpop.gremlin.structure.VertexTest", 
method="*", reason="no"), // pss
+  new 
Graph.OptOut(test="org.apache.tinkerpop.gremlin.structure.util.detached.DetachedVertexPropertyTest",
 method="*", reason="no"),
+  // passed: all, failed: none
 
-  new 
Graph.OptOut(test="org.apache.tinkerpop.gremlin.structure.util.detached.DetachedEdgeTest",
 method="*", reason="no"), // pass
+  new Graph.OptOut(test="org.apache.tinkerpop.gremlin.structure.GraphTest", 
method="*", reason="no"),
+  // passed: , failed:
+  // shouldIterateEdgesWithCustomIdSupportUsingStringRepresentations, 
shouldTraverseInOutFromVertexWithMultipleEdgeLabelFilter,
+  // shouldRemoveVertices, 
shouldHaveExceptionConsistencyWhenAssigningSameIdOnVertex, shouldRemoveEdges, 
shouldEvaluateConnectivityPatterns,
+  // shouldIterateEdgesWithCustomIdSupportUsingEdge, 
shouldTraverseInOutFromVertexWithSingleEdgeLabelFilter, 
shouldIterateEdgesWithCustomIdSupportUsingEdges,
+  // shouldRemoveEdgesWithoutConcurrentModificationException, 
shouldIterateEdgesWithCustomIdSupportUsingStringRepresentation
 
-  new 
Graph.OptOut(test="org.apache.tinkerpop.gremlin.structure.util.detached.DetachedGraphTest",
 method="*", reason="no"), // pass all ignored
-  new 
Graph.OptOut(test="org.apache.tinkerpop.gremlin.structure.util.detached.DetachedPropertyTest",
 method="*", reason="no"), // pass
-  new 
Graph.OptOut(test="org.apache.tinkerpop.gremlin.structure.util.detached.DetachedVertexPropertyTest",
 method="*", reason="no"), // pass
+  new 
Graph.OptOut(test="org.apache.tinkerpop.gremlin.structure.util.reference.ReferenceEdgeTest",
 method="*", reason="no"),
+  // passed: , failed: shouldNotEvaluateToEqualDifferentId, 
shouldConstructReferenceEdge
 
-  new Graph.OptOut(test="org.apache.tinkerpop.gremlin.structure.GraphTest", 
method="*", reason="no"), // pass
+  new 
Graph.OptOut(test="org.apache.tinkerpop.gremlin.structure.util.reference.ReferenceVertexPropertyTest",
 method="*", reason="no"),
+  // passed: all, failed: none
 
-  new 
Graph.OptOut(test="org.apache.tinkerpop.gremlin.structure.util.reference.ReferenceEdgeTest",
 method="*", reason="no"), // pass
-  new 
Graph.OptOut(test="org.apache.tinkerpop.gremlin.structure.util.reference.ReferenceGraphTest",
 method="*", reason="no"), // pass
-  new 
Graph.OptOut(test="org.apache.tinkerpop.gremlin.structure.util.reference.ReferenceVertexPropertyTest",
 method="*", reason="no"), // pass
-  new 
Graph.OptOut(test="org.apache.tinkerpop.gremlin.structure.util.reference.ReferenceVertexTest",
 method="*", reason="no"), // pass
+  new 
Graph.OptOut(test="org.apache.tinkerpop.gremlin.structure.util.reference.ReferenceGraphTest",
 method="*", reason="no"),
+  // passed: all, failed: none, all ignored
+  new 
Graph.OptOut(test="org.apache.tinkerpop.gremlin.structure.util.reference.ReferenceVertexTest",
 method="*", reason="no"),
+  // passed: all, failed: none, all ignored
 
   // not yet supported
-  new 
Graph.OptOut(test="org.apache.tinkerpop.gremlin.structure.SerializationTest", 
method="*", reason="no"),
-  new 
Graph.OptOut(test="org.apache.tinkerpop.gremlin.structure.TransactionTest", 
method="*", reason="no"),
-  new 
Graph.OptOut(test="org.apache.tinkerpop.gremlin.structure.VariablesTest", 
method="*", reason="no"),
+  new 
Graph.OptOut(test="org.apache.tinkerpop.gremlin.structure.SerializationTest", 
method="*", reason="no"), // 10/16 failed.
+  new 
Graph.OptOut(test="org.apache.tinkerpop.gremlin.structure.TransactionTest", 
method="*", reason="no"), // all ignored since supportTransaction is false.
+  new 
Graph.OptOut(test="org.apache.tinkerpop.gremlin.structure.VariablesTest", 
method="*", reason="no"), // all failed since implementation is missing.
 
-  new 
Graph.OptOut(test="org.apache.tinkerpop.gremlin.structure.io.IoCustomTest", 
method="*", reason="no"),
-  new 
Graph.OptOut(test="org.apache.tinkerpop.gremlin.structure.io.IoEdgeTest", 
method="*", reason="no"),
-  new 
Graph.OptOut(test="org.apache.tinkerpop.gremlin.structure.io.IoGraphTest", 
method="*", reason="no"),
-  new 
Graph.OptOut(test="org.apache.tinkerpop.gremlin.structure.io.IoPropertyTest", 
method="*", reason="no"),
-  new Graph.OptOut(test="org.apache.tinkerpop.gremlin.structure.io.IoTest", 
method="*", reason="no"),
-  new 
Graph.OptOut(test="org.apache.tinkerpop.gremlin.structure.io.IoVertexTest", 
method="*", reason="no"),
+  new 
Graph.OptOut(test="org.apache.tinkerpop.gremlin.structure.io.IoCustomTest", 
method="*", reason="no"), // all ignored.
+  new 
Graph.OptOut(test="org.apache.tinkerpop.gremlin.structure.io.IoEdgeTest", 
method="*", reason="no"), // all failed.
+  new 
Graph.OptOut(test="org.apache.tinkerpop.gremlin.structure.io.IoGraphTest", 
method="*", reason="no"), // all failed.
+  new 
Graph.OptOut(test="org.apache.tinkerpop.gremlin.structure.io.IoPropertyTest", 
method="*", reason="no"), // all failed.
+  new Graph.OptOut(test="org.apache.tinkerpop.gremlin.structure.io.IoTest", 
method="*", reason="no"), // all failed.
+  new 
Graph.OptOut(test="org.apache.tinkerpop.gremlin.structure.io.IoVertexTest", 
method="*", reason="no"), // all failed.
 
-  new 
Graph.OptOut(test="org.apache.tinkerpop.gremlin.structure.util.star.StarGraphTest",
 method="*", reason="no"),
+  new 
Graph.OptOut(test="org.apache.tinkerpop.gremlin.structure.util.star.StarGraphTest",
 method="*", reason="no"), // failed on shouldHandleSelfLoops
 
-  new 
Graph.OptOut(test="org.apache.tinkerpop.gremlin.algorithm.generator.CommunityGeneratorTest",
 method="*", reason="no"),
-  new 
Graph.OptOut(test="org.apache.tinkerpop.gremlin.algorithm.generator.DistributionGeneratorTest",
 method="*", reason="no")
+  new 
Graph.OptOut(test="org.apache.tinkerpop.gremlin.algorithm.generator.CommunityGeneratorTest",
 method="*", reason="no"), // all failed.
+  new 
Graph.OptOut(test="org.apache.tinkerpop.gremlin.algorithm.generator.DistributionGeneratorTest",
 method="*", reason="no") // all failed.
 ))
 class S2Graph(_config: Config)(implicit val ec: ExecutionContext) extends 
Graph {
 

http://git-wip-us.apache.org/repos/asf/incubator-s2graph/blob/c508def0/s2core/src/test/scala/org/apache/s2graph/core/tinkerpop/S2GraphProvider.scala
----------------------------------------------------------------------
diff --git 
a/s2core/src/test/scala/org/apache/s2graph/core/tinkerpop/S2GraphProvider.scala 
b/s2core/src/test/scala/org/apache/s2graph/core/tinkerpop/S2GraphProvider.scala
index 865717d..0ab3dc7 100644
--- 
a/s2core/src/test/scala/org/apache/s2graph/core/tinkerpop/S2GraphProvider.scala
+++ 
b/s2core/src/test/scala/org/apache/s2graph/core/tinkerpop/S2GraphProvider.scala
@@ -71,7 +71,7 @@ class S2GraphProvider extends AbstractGraphProvider {
     val defaultServiceColumn = s2Graph.DefaultColumn
 
     val columnNames = Set(defaultServiceColumn.columnName, "person", 
"software", "product", "dog")
-    val labelNames = Set("knows", "created", "bought", "test", "self", 
"friends", "friend", "hate", "collaborator", "test1", "test2", "test3", "pets", 
"walks", "knows")
+    val labelNames = Set("knows", "created", "bought", "test", "self", 
"friends", "friend", "hate", "collaborator", "test1", "test2", "test3", "pets", 
"walks")
 
     Management.deleteService(defaultService.serviceName)
     columnNames.foreach { columnName =>

Reply via email to