[incubator-samoa] branch master updated: SAMOA-78: Accept newly arriving values of nominal attributes

[csterling]

This is an automated email from the ASF dual-hosted git repository.

csterling pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-samoa.git


The following commit(s) were added to refs/heads/master by this push:
     new 18d0ce2  SAMOA-78: Accept newly arriving values of nominal attributes
18d0ce2 is described below

commit 18d0ce2fc51de9d51d97688f5057f64f84d06164
Author: Maciej Grzenda <maciej.grze...@gmail.com>
AuthorDate: Mon Dec 11 16:21:03 2017 +0100

    SAMOA-78: Accept newly arriving values of nominal attributes
    
    Fix #75
---
 .../src/main/java/org/apache/samoa/instances/Attribute.java       | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git 
a/samoa-instances/src/main/java/org/apache/samoa/instances/Attribute.java 
b/samoa-instances/src/main/java/org/apache/samoa/instances/Attribute.java
index 128ace7..4f49b43 100644
--- a/samoa-instances/src/main/java/org/apache/samoa/instances/Attribute.java
+++ b/samoa-instances/src/main/java/org/apache/samoa/instances/Attribute.java
@@ -243,8 +243,14 @@ public class Attribute implements Serializable {
       }
     }
     Integer val = (Integer) this.valuesStringAttribute.get(value);
+    
+    // in case this value was not on a list of unique values of nominal 
attribute yet, add it
+    // this means, the list of values can be extended with new entries 
arriving in the stream
     if (val == null) {
-      return -1;
+      int currentValueCount=this.valuesStringAttribute.size();
+      this.valuesStringAttribute.put(value,currentValueCount);
+      this.attributeValues.add(value);
+      return currentValueCount;
     } else {
       return val.intValue();
     }