[
https://issues.apache.org/jira/browse/SAMZA-93?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris Riccomini updated SAMZA-93:
---------------------------------
Attachment: SAMZA-93.1.patch
Looks good. I ran locally and found a few issues:
# Missed a , before the 'eot' line.
# MockKafkaProducer was missing a header.
# RAT was catching Javadocs files.
# RAT was catching Eclipse (.classpath, .settings, .cache) files.
Attaching a patch that fixes all of these issues.
[~davidzchen], could you verify?
> Gradle check task should fail the build if license headers are missing
> ----------------------------------------------------------------------
>
> Key: SAMZA-93
> URL: https://issues.apache.org/jira/browse/SAMZA-93
> Project: Samza
> Issue Type: Improvement
> Reporter: Jakob Homan
> Assignee: David Chen
> Priority: Minor
> Attachments: SAMZA-93.0.patch, SAMZA-93.1.patch
>
>
> Right now the gradle check task logs a warning for files without license
> headers, but it should fail the build. Also, committers should be sure to
> run check before committing.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
