[
https://issues.apache.org/jira/browse/SAMZA-633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14393607#comment-14393607
]
Chris Riccomini commented on SAMZA-633:
---------------------------------------
Hey Dan, I'm having trouble applying your patch. Am I missing anything?
{noformat}
$ curl -O
https://issues.apache.org/jira/secure/attachment/12709020/0001-Pass-properties-through-to-the-Kafka-Encoder-and-Dec.patch
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
100 4049 100 4049 0 0 12746 0 --:--:-- --:--:-- --:--:-- 21310
$ git apply 0001-Pass-properties-through-to-the-Kafka-Encoder-and-Dec.patch
fatal: corrupt patch at line 55
{noformat}
> Pass configuration though to Kafka encoder/decoder in KafkaSerdeFactory
> -----------------------------------------------------------------------
>
> Key: SAMZA-633
> URL: https://issues.apache.org/jira/browse/SAMZA-633
> Project: Samza
> Issue Type: Improvement
> Components: kafka
> Affects Versions: 0.9.0
> Environment: Any
> Reporter: Dan Harvey
> Assignee: Dan Harvey
> Priority: Minor
> Fix For: 0.10.0
>
> Attachments:
> 0001-Pass-properties-through-to-the-Kafka-Encoder-and-Dec.patch
>
>
> The KafkaSerdeFactory currently constructs Kafka encoders and decoders using
> the default constructor with no parameters. Kafka generally constructs these
> by passing in a VerifiableProperties to allow the constructor to configure
> them.
> I think we can do this by taking properties out of Samza's configuration map
> as with the kafka encoder/decoder setting then passing these through to the
> constructors.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
