[
https://issues.apache.org/jira/browse/SAMZA-691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14567786#comment-14567786
]
Yan Fang commented on SAMZA-691:
--------------------------------
Hi [~jjung], thank you very much.
1. added you to the contributor.
2. RB looks good. Only one naming convention, it would be greate if you can
change it.
3. could you upload the patch in the JIRA? This is how Apache gets granted.
> messages-chosen counter in SystemConsumersMetrics registerSystemStream
> without identifying the partition
> ---------------------------------------------------------------------------------------------------------
>
> Key: SAMZA-691
> URL: https://issues.apache.org/jira/browse/SAMZA-691
> Project: Samza
> Issue Type: Bug
> Components: metrics
> Reporter: Luis De Pombo
> Priority: Minor
> Labels: newbie
>
> Running a samza job that consumes from a topic with 3 partitions (3 samza
> tasks) in the same container we get the following message for collision of
> metric names:
> {code}
> 2015-05-27 15:10:32 SamzaGraphiteReporter [INFO] Exception while registering
> for onCounter: java.lang.IllegalArgumentException: A metric named
> org_apache_samza_system_SystemConsumersMetrics.samza-container-0.kafka-trip_details-messages-chosen
> already exists
> 2015-05-27 15:10:32 SamzaGraphiteReporter [INFO] Exception while registering
> for onCounter: java.lang.IllegalArgumentException: A metric named
> org_apache_samza_system_SystemConsumersMetrics.samza-container-0.kafka-trip_details-messages-chosen
> already exists
> {code}
> Samza counter "messages-chosen" is registered per system stream without
> identifying by partition or source. It must include partition or only include
> the system so the metric name can be unique under all scenarios.
> {code}
> def registerSystemStream(systemStream: SystemStream) {
> systemStreamMessagesChosen += systemStream ->
> newCounter("%s-%s-messages-chosen" format (systemStream.getSystem,
> systemStream.getStream))
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
