[ 
https://issues.apache.org/jira/browse/SAMZA-474?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14579758#comment-14579758
 ] 

Yan Fang commented on SAMZA-474:
--------------------------------

The patch is good. It's better if you can remove the whitespace mentioned in 
the RB. Thanks. :)

> check-all script should fail more gracefully in the absence of gradlew
> ----------------------------------------------------------------------
>
>                 Key: SAMZA-474
>                 URL: https://issues.apache.org/jira/browse/SAMZA-474
>             Project: Samza
>          Issue Type: Improvement
>          Components: build, test
>    Affects Versions: 0.8.0
>            Reporter: Jakob Homan
>            Assignee: Aleksandar Pejakovic
>            Priority: Minor
>             Fix For: 0.10.0
>
>         Attachments: SAMZA-TASK-474.0.patch
>
>
> The check-all script assumes the presence of gradlew, which may not be 
> present for a new source check out.  
> {noformat}✔ ~/samzarc/apache-samza-0.8.0-incubating-src
> jghoman-vm 10:23 $ bin/check-all.sh
> ------------- Running check task against JDK6/Scala 2.9.2/YARN 2.4.0
> bin/check-all.sh: line 70: 
> /home/jghoman/samzarc/apache-samza-0.8.0-incubating-src/gradlew: No such file 
> or directory
> {noformat}
> It would be better if the script either ran the bootstrap check or checked 
> for the presence of gradlew and spit out a more useful message should it not 
> be available.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to