[
https://issues.apache.org/jira/browse/SAMZA-693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14601726#comment-14601726
]
Yan Fang commented on SAMZA-693:
--------------------------------
RB: https://reviews.apache.org/r/35445/ for other guys' convenience.
Hi [~initialcontext], I think the code is very good.
1. Just a few nits about the format in the RB.
2. can not apply the patch in this JIRA, got
{code}
fatal: git diff header lacks filename information when removing 1 leading
pathname component (line 5)
{code}
3. do you mind adding a doc? I think we can create a new directory under
docs/learn/documentation/versioned/, called something like "Integrated Systems"
(maybe a better name? :) ). And put the doc under that directory.
4. in terms of making the output format pluggable, agreed with you. we can open
a new ticket for that.
Thank you!
> Add simple HDFS Producer system to Samza
> ----------------------------------------
>
> Key: SAMZA-693
> URL: https://issues.apache.org/jira/browse/SAMZA-693
> Project: Samza
> Issue Type: Sub-task
> Components: yarn
> Reporter: Eli Reisman
> Assignee: Eli Reisman
> Priority: Trivial
> Attachments: SAMZA-693-1.patch, SAMZA-693-2.patch, SAMZA-693-3.patch
>
>
> Add a simple HDFS producer and related utilities. I've been using a version
> of this. Initial patch comes with a very basic test and it's own subproject
> setup which may or may not be what we want?
> Thanks!
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
