[ 
https://issues.apache.org/jira/browse/SAMZA-737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14633817#comment-14633817
 ] 

Yan Fang commented on SAMZA-737:
--------------------------------

{quote}
 I did a git grep through the code and found that "topic-level-property" is 
never used in the code. Was it used before?
{quote}

No, I do not think so. Backtracked the code change, the answer is still no. I 
think we can change the document, or change the code, both ways look good to 
me. If we decide to use "stores.store-name.changelog.topic-level-property", 
"replication.factor" becomes part of that, right? (But I do not know why in 
[Kafka's topic level 
config|http://kafka.apache.org/documentation.html#configuration], 
"replication.factor" is not part of the Topic-level configuration)




> config docs: property name stores.store-name.changelog.topic-level-property 
> is not effective
> --------------------------------------------------------------------------------------------
>
>                 Key: SAMZA-737
>                 URL: https://issues.apache.org/jira/browse/SAMZA-737
>             Project: Samza
>          Issue Type: Bug
>          Components: docs
>    Affects Versions: 0.9.0
>            Reporter: Carl Laird
>            Priority: Minor
>
> In the following configuration doc:
> http://samza.apache.org/learn/documentation/0.9/jobs/configuration-table.html
> The property stores.store-name.changelog.topic-level-property
> should be  stores.store-name.changelog.kafka.topic-level-property



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to