[
https://issues.apache.org/jira/browse/SAMZA-733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14635471#comment-14635471
]
Yan Fang commented on SAMZA-733:
--------------------------------
[~theduderog], thank you. The patch looks great. And all the tests are passed.
A few suggestions I put in the RB you may want to consider. :) Thank you.
> Add metrics for Elasticsearch Producer
> --------------------------------------
>
> Key: SAMZA-733
> URL: https://issues.apache.org/jira/browse/SAMZA-733
> Project: Samza
> Issue Type: Improvement
> Components: metrics
> Reporter: Roger Hoover
> Assignee: Roger Hoover
> Priority: Minor
> Fix For: 0.10.0
>
> Attachments: SAMZA-733-WITH-METRICS-BASE-CLASS.patch,
> SAMZA-733.patch, SAMZA-733.patch, SAMZA-733.patch
>
>
> Add metrics for Elasticsearch producers. For now, we'll only track success
> events (number of successful bulk sends, number of documents inserted, and
> number of documents updated). Since the current ES producer fails the job
> when ES returns an error, there's not benefit yet to tracking negative events
> because Samza does not seem to flush metrics before shutting down (at least
> when I tested with ThreadJob.
> I've implemented metrics here
> (https://github.com/Quantiply/rico/tree/master/samza-elasticsearch/src/main/java/org/apache/samza/system/elasticsearch)
> and will work on creating a patch.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
