[
https://issues.apache.org/jira/browse/SAMZA-676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14706161#comment-14706161
]
Yan Fang commented on SAMZA-676:
--------------------------------
Need to change at least the following two parts:
1. the sspToString and stringToSsp methods, those are used to
serialize/deserialize the json to pass the JobModel between AM and containers.
See
[here|https://github.com/apache/samza/blob/master/samza-core/src/main/scala/org/apache/samza/util/Util.scala#L225-L242].
2. also affect the checkpoint . See
[here|https://github.com/apache/samza/blob/master/samza-core/src/main/java/org/apache/samza/coordinator/stream/messages/SetCheckpoint.java#L63],
and
[here|https://github.com/apache/samza/blob/master/samza-core/src/main/java/org/apache/samza/coordinator/stream/messages/SetCheckpoint.java#L70].
This looks ok. I just have not looked at it very carefully.
In users experience:
1. not sure if we want to include the "isBroadcast" in the toString method,
this may also affect the user's code which is based on the toString method.
2. and hope they are not using the sspToString and stringToSsp methods (they
are not in the API though).
> Implement Broadcast Stream
> --------------------------
>
> Key: SAMZA-676
> URL: https://issues.apache.org/jira/browse/SAMZA-676
> Project: Samza
> Issue Type: Improvement
> Components: container
> Reporter: Yan Fang
> Assignee: Yan Fang
> Attachments: BroadcastStreamDesign.md, BroadcastStreamDesign.pdf,
> BroadcastStreamDesign_1.md, BroadcastStreamDesign_1.pdf, SAMZA-676.2.patch,
> SAMZA-676.3.patch, SAMZA-676.4.patch, SAMZA-676.5.patch
>
>
> There are a lot of discussion in SAMZA-353 about assigning the same SSP to
> multiple taskNames. This ticket is a subset of the discussion. Only focus on
> the broadcast stream implementation.
> The goal is to assign one SSP to all the taskNames.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
