[ https://issues.apache.org/jira/browse/SAMZA-779?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14935610#comment-14935610 ]
Navina Ramesh commented on SAMZA-779: ------------------------------------- Here is the RB - https://reviews.apache.org/r/38832 [~jmaes] I gave you a +1 on the RB. Can you please upload the patch here and mark the status of the JIRA as "Patch Available"? In the future, update the JIRA with the RB link as well. This is convenient for the reviewers and makes sure that your patch gets noticed for review. Thanks for your contribution :) > Remove the dependency on JUnit from SamzaTaskManager > ---------------------------------------------------- > > Key: SAMZA-779 > URL: https://issues.apache.org/jira/browse/SAMZA-779 > Project: Samza > Issue Type: Bug > Components: yarn > Affects Versions: 0.10.0 > Reporter: Jake Maes > Assignee: Jake Maes > > Remove the dependency on JUnit, which shouldn't be in production code and in > some environments, could be explicitly excluded and cause build errors. > Interestingly, gradle allowed the dependency even though we only ever add > JUnit as a testCompile dependency. It looks like this is due to a transitive > dependency. > Snippet from the command "./gradlew :samza-yarn:dependencies": > compile - Compile classpath for source set 'main'. > ... > \--- org.apache.zookeeper:zookeeper:3.3.4 > +--- log4j:log4j:1.2.15 -> 1.2.17 > \--- jline:jline:0.9.94 > \--- junit:junit:3.8.1 -- This message was sent by Atlassian JIRA (v6.3.4#6332)