[
https://issues.apache.org/jira/browse/SAMZA-436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14952883#comment-14952883
]
Aleksandar Bircakovic commented on SAMZA-436:
---------------------------------------------
Method putAll is tested in TestKeyValueStore and ./gradlew clean build finished
successfully with no errors so I think it works now. Hello Samza was working
for some time with no errors. One thing that bothers me is possibility of
resource leak. In this code batch is not closed at the end, there is no close
method in WriteBatch anymore despite
[documentation|https://github.com/fusesource/rocksdbjni/blob/master/readme.md]
saying it should be used.
> Update RocksDB KV's putAll to use write batch
> ---------------------------------------------
>
> Key: SAMZA-436
> URL: https://issues.apache.org/jira/browse/SAMZA-436
> Project: Samza
> Issue Type: Bug
> Components: kv
> Reporter: Chris Riccomini
> Assignee: Aleksandar Bircakovic
> Attachments: SAMZA-436.0.patch
>
>
> In SAMZA-236, we don't use write batch inside our RocksDB putAll
> implementation. Instead, we call put sequentially. The reason for this is
> [this|https://github.com/facebook/rocksdb/issues/262] issue that we were
> seeing, where RocksDB putAll crashes.
> Once the issue is resolved, we should update our RocksDB implementation to
> use the proper writeBatch API.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
