Repository: samza Updated Branches: refs/heads/master 0fb058610 -> 0bacbbe19
SAMZA-846 : Refactor logging in ContainerAllocator and LocalityManager that is flooding the AM log Project: http://git-wip-us.apache.org/repos/asf/samza/repo Commit: http://git-wip-us.apache.org/repos/asf/samza/commit/0bacbbe1 Tree: http://git-wip-us.apache.org/repos/asf/samza/tree/0bacbbe1 Diff: http://git-wip-us.apache.org/repos/asf/samza/diff/0bacbbe1 Branch: refs/heads/master Commit: 0bacbbe192d6f97ab6a2ab340e449be732aa3621 Parents: 0fb0586 Author: Navina <[email protected]> Authored: Tue Dec 22 15:52:52 2015 -0800 Committer: Navina <[email protected]> Committed: Tue Dec 22 15:52:52 2015 -0800 ---------------------------------------------------------------------- .../main/java/org/apache/samza/container/LocalityManager.java | 6 +++++- .../java/org/apache/samza/job/yarn/ContainerRequestState.java | 4 ++-- 2 files changed, 7 insertions(+), 3 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/samza/blob/0bacbbe1/samza-core/src/main/java/org/apache/samza/container/LocalityManager.java ---------------------------------------------------------------------- diff --git a/samza-core/src/main/java/org/apache/samza/container/LocalityManager.java b/samza-core/src/main/java/org/apache/samza/container/LocalityManager.java index 86c9e9b..acf9352 100644 --- a/samza-core/src/main/java/org/apache/samza/container/LocalityManager.java +++ b/samza-core/src/main/java/org/apache/samza/container/LocalityManager.java @@ -101,10 +101,14 @@ public class LocalityManager extends AbstractCoordinatorStreamManager { localityMappings.put(SetContainerHostMapping.HOST_KEY, mapping.getHostLocality()); localityMappings.put(SetContainerHostMapping.JMX_URL_KEY, mapping.getJmxUrl()); localityMappings.put(SetContainerHostMapping.JMX_TUNNELING_URL_KEY, mapping.getJmxTunnelingUrl()); - log.info(String.format("Read locality for container %s: %s", mapping.getKey(), localityMappings)); allMappings.put(Integer.parseInt(mapping.getKey()), localityMappings); } containerToHostMapping = Collections.unmodifiableMap(allMappings); + + for (Map.Entry<Integer, Map<String, String>> entry : containerToHostMapping.entrySet()) { + log.debug(String.format("Locality for container %s: %s", entry.getKey(), entry.getValue())); + } + return allMappings; } http://git-wip-us.apache.org/repos/asf/samza/blob/0bacbbe1/samza-yarn/src/main/java/org/apache/samza/job/yarn/ContainerRequestState.java ---------------------------------------------------------------------- diff --git a/samza-yarn/src/main/java/org/apache/samza/job/yarn/ContainerRequestState.java b/samza-yarn/src/main/java/org/apache/samza/job/yarn/ContainerRequestState.java index 4b36a91..ab3061e 100644 --- a/samza-yarn/src/main/java/org/apache/samza/job/yarn/ContainerRequestState.java +++ b/samza-yarn/src/main/java/org/apache/samza/job/yarn/ContainerRequestState.java @@ -207,7 +207,7 @@ public class ContainerRequestState { if (hostAffinityEnabled) { if (requestsQueue.isEmpty()) { - log.info("Requests Queue is empty. Should clear up state."); + log.debug("Container Requests Queue is empty."); List<String> allocatedHosts = getAllocatedHosts(); for (String host : allocatedHosts) { @@ -224,7 +224,7 @@ public class ContainerRequestState { } } else { if (requestsQueue.isEmpty()) { - log.info("No more pending requests in queue."); + log.debug("No more pending requests in Container Requests Queue."); List<Container> availableContainers = getContainersOnAHost(ANY_HOST); while(availableContainers != null && !availableContainers.isEmpty()) {
