[
https://issues.apache.org/jira/browse/SAMZA-893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15197922#comment-15197922
]
Jake Maes commented on SAMZA-893:
---------------------------------
[~navina]
To further clarify, with the current conditional:
if (expired || !hasAllocatedContainer(ANY_HOST)) {
// log message and break
}
once the "expired" flag is true, it just prints log messages and retries. It
NEVER runs the container on ANY_HOST. So it will just keep retrying and if it
never gets a container on the preferred host, the job never starts.
This is unquestionably broken in its current state.
So please consider that if you want to hold onto this bug.
> Fix a bug with host affinity request expiration introduced in SAMZA-867
> -----------------------------------------------------------------------
>
> Key: SAMZA-893
> URL: https://issues.apache.org/jira/browse/SAMZA-893
> Project: Samza
> Issue Type: Bug
> Reporter: Jake Maes
> Assignee: Jake Maes
> Attachments: SAMZA-893.patch
>
>
> The expiration logic change in the patch for SAMZA-867 was wrong. It
> simplified the conditional, but would cause expired requests to never get
> rescheduled on ANY_HOST.
> This ticket is to fix that logic and the unit tests, which didn't fail after
> the change.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
