[ 
https://issues.apache.org/jira/browse/SAMZA-1049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15678290#comment-15678290
 ] 

Shanthoosh Venkataraman commented on SAMZA-1049:
------------------------------------------------

I tried locally with the patch, it works for me. I have uploaded the patch 
again. 

samza } git apply ~/Downloads/rb53297.patch                                     
                                                                                
                 {*master*} 17:09:13 
 samza } git status                                                             
                                                                                
                  {*master*} 17:09:16 
On branch master
Your branch is up-to-date with 'origin/master'.
Changes not staged for commit:
  (use "git add <file>..." to update what will be committed)
  (use "git checkout -- <file>..." to discard changes in working directory)
        modified:   docs/learn/documentation/versioned/rest/monitors.md
        modified:   
samza-core/src/main/scala/org/apache/samza/container/SamzaContainer.scala
        modified:   
samza-core/src/main/scala/org/apache/samza/metrics/ContainerProcessManagerMetrics.scala
        modified:   
samza-rest/src/main/java/org/apache/samza/monitor/MonitorFactory.java
        modified:   
samza-rest/src/main/java/org/apache/samza/monitor/MonitorLoader.java
        modified:   
samza-rest/src/main/java/org/apache/samza/monitor/SamzaMonitorService.java
        modified:   
samza-rest/src/main/java/org/apache/samza/rest/SamzaRestService.java
        modified:   
samza-rest/src/test/java/org/apache/samza/monitor/TestMonitorService.java
        modified:   
samza-rest/src/test/java/org/apache/samza/monitor/mock/DummyMonitorFactory.java
        modified:   
samza-rest/src/test/java/org/apache/samza/monitor/mock/ExceptionThrowingMonitorFactory.java
        modified:   
samza-rest/src/test/java/org/apache/samza/monitor/mock/MockMonitorFactory.java
        modified:   
samza-yarn/src/main/scala/org/apache/samza/job/yarn/SamzaAppMasterMetrics.scala



> Enable support for reporting metrics from Monitors in SamzaRest.
> ----------------------------------------------------------------
>
>                 Key: SAMZA-1049
>                 URL: https://issues.apache.org/jira/browse/SAMZA-1049
>             Project: Samza
>          Issue Type: New Feature
>            Reporter: Shanthoosh Venkataraman
>            Assignee: Shanthoosh Venkataraman
>            Priority: Minor
>         Attachments: rb53297.patch
>
>
>                  Metrics is an important and adequate mechanism to track and 
> measure the behavior of the monitors in an environment and define alerts 
> based upon them. In majority of the cases, tracking the behavior of the 
> monitors through metrics will be useful in debugging. 
>                  This ticket aims at enabling the creation and reporting of 
> metrics from the monitors in `SamzaRest` package. Metrics can be reported to 
> multiple sinks and configuration for each sink should be defined in 
> `SamzaRest` configuration.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to