[ 
https://issues.apache.org/jira/browse/SAMZA-1055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15709945#comment-15709945
 ] 

ASF GitHub Bot commented on SAMZA-1055:
---------------------------------------

Github user asfgit closed the pull request at:

    https://github.com/apache/samza/pull/26


> Disable broken tests in SamzaRest due to Jetty version upgrade
> --------------------------------------------------------------
>
>                 Key: SAMZA-1055
>                 URL: https://issues.apache.org/jira/browse/SAMZA-1055
>             Project: Samza
>          Issue Type: Bug
>            Reporter: Shanthoosh Venkataraman
>
> There was an jetty version upgrade in Samza  from version 8 to 9 across all 
> modules. This has broken a Test in SamzaRest module due to following reasons.
> a) In the recent Jetty API, the following public method present in the class 
> org.eclipse.jetty.util.component.ContainerLifeCycle exposes an package 
> private param(Managed). 
> `public boolean addBean(Object o, Managed managed)` . This however, causes 
> mockito which uses reflection to create mock instances to fail during the 
> mock creation in tests. More details about this can be found here : 
> https://github.com/mockito/mockito/issues/233
> b) Jetty 9 api is backward incompatible with Jetty 8. Some of the methods in 
> org.eclipse.jetty.server.Server class were made final, hence making these 
> methods impossible to be mocked with Mockito. 
> Before the permanent solution is found and to keep the samza master build 
> unbroken, this SamzaRest test will be disabled temporarily. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to