[
https://issues.apache.org/jira/browse/SAMZA-1076?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15803121#comment-15803121
]
ASF GitHub Bot commented on SAMZA-1076:
---------------------------------------
GitHub user sborya opened a pull request:
https://github.com/apache/samza/pull/39
SAMZA-1076: getKafkaChangelogEnabledStores() should use
StorageConfig.getChangelo…
getKafkaChangelogEnabledStores() should use
StorageConfig.getChangelogStream to get changelog system.stream
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/sborya/samza KafkConfigForChangelogStream
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/samza/pull/39.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #39
----
commit d44dd982fae508b5347953c2ec33cd64c23c4e0a
Author: Boris Shkolnik <[email protected]>
Date: 2017-01-06T00:45:29Z
getKafkaChangelogEnabledStores() should use
StorageConfig.getChangelogSTream to get changelog system.stream
----
> getKafkaChangelogEnabledStores() should use StorageConfig.getChangelogStream
> to get changelog system.stream
> -----------------------------------------------------------------------------------------------------------
>
> Key: SAMZA-1076
> URL: https://issues.apache.org/jira/browse/SAMZA-1076
> Project: Samza
> Issue Type: Bug
> Reporter: Boris Shkolnik
> Assignee: Boris Shkolnik
>
> Currently it gets the value for changelog directly from the config and tries
> to parse it assuming format 'system.stream'. But since Samza-1060, changelog
> could be in format 'stream' (if job.changelog.system setting is present).
> getKafkaChangelogEnabledStores needs to use StorageConfig.getChangelog to
> account for the possibility instead of getting it directly.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
