[ 
https://issues.apache.org/jira/browse/SAMZA-1112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15903845#comment-15903845
 ] 

ASF GitHub Bot commented on SAMZA-1112:
---------------------------------------

GitHub user twbecker opened a pull request:

    https://github.com/apache/samza/pull/80

    SAMZA-1112:BrokerProxy does not log fatal errors

    Add an UncaughtExceptionHandler to the broker proxy thread so
    failures there get logged.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/TiVo/samza SAMZA-1112

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/samza/pull/80.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #80
    
----
commit a2e00bbbf773e340fb1fd0617a4ac3945d58c365
Author: Tommy Becker <[email protected]>
Date:   2017-03-09T20:47:46Z

    Fix SAMZA-1112
    
    Add an UncaughtExceptionHandler to the broker proxy thread so
    failures there get logged.

----


> BrokerProxy does not log fatal errors
> -------------------------------------
>
>                 Key: SAMZA-1112
>                 URL: https://issues.apache.org/jira/browse/SAMZA-1112
>             Project: Samza
>          Issue Type: Bug
>    Affects Versions: 0.12.0
>            Reporter: Tommy Becker
>            Assignee: Tommy Becker
>
> We hit an issue today where having a large backlog of messages to process 
> caused an OutOfMemoryError in one our our jobs, presumably due to the 
> BrokerProxy's default buffer size of 50k messages being too large. The issue 
> though was that the error was not logged, and from the logs it appeared that 
> the job just spontaneously exited. 
> Looking at the BrokerProxy, there is no UncaughtExceptionHandler set for its 
> thread, so any fatal errors only go to stderr.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to