[
https://issues.apache.org/jira/browse/SAMZA-1125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15904211#comment-15904211
]
Navina Ramesh commented on SAMZA-1125:
--------------------------------------
[~xinyu]
> The problem I see is that stopContainer() doesn't wait for the container
> being fully shutdown. It just sets the flag and return
Yes. stopContainer sets a flag in the Runloop. However, it also waits on the
future of the container thread.So, once the runloop exits because of the flag,
all the systems are shutdown in Samza Container and it returns the future.
StopContainer() is already waiting for the container to stop. It is doing what
we want. Perhaps you missed to see the waiting on the future part?
> Container.shutdown() only stops the runloop
> -------------------------------------------
>
> Key: SAMZA-1125
> URL: https://issues.apache.org/jira/browse/SAMZA-1125
> Project: Samza
> Issue Type: New Feature
> Reporter: Xinyu Liu
> Assignee: Navina Ramesh
>
> Currently SamzaContainer.shutdown() only stops the RunLoop. Seems to me all
> the dependencies used by the container are not properly shutdown. E.g. the
> kafka system consumer/producer will not be shut down. In standalone case
> (ZkJobCoordinator.java), the next time controller.startContainer() will
> create the container with all these dependencies again. The Kafka
> producers/consumers will be created again without closing the previous ones.
> Please verify this is a problem and needs to be fixed.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
