[ 
https://issues.apache.org/jira/browse/SAMZA-1138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15907727#comment-15907727
 ] 

ASF GitHub Bot commented on SAMZA-1138:
---------------------------------------

GitHub user logarithm opened a pull request:

    https://github.com/apache/samza/pull/84

    SAMZA-1138: Yarn capability check is broken

    After migration from yarn.container.* properties to 
cluster-manager.container.* properties we have to use either of them and 
ClusterManagerConfig provides backward compatibility for these properties. But 
in YarnClusterResourceManager only old properties are used (from YarnConfig), 
hence if job config migrated to new cluster-manager.* properties names then 
check will be evaluated against default values, not against actual values.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/metamx/samza yarn-properties-fix

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/samza/pull/84.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #84
    
----
commit 3c407851e281e2b372ecae0ca4eca7b2caf1d1e0
Author: Maksim Logvinenko <[email protected]>
Date:   2017-03-13T15:52:36Z

    cluster-manager.container.* properties were ignored in 
YarnClusterResourceManager

----


> Yarn capability check is broken
> -------------------------------
>
>                 Key: SAMZA-1138
>                 URL: https://issues.apache.org/jira/browse/SAMZA-1138
>             Project: Samza
>          Issue Type: Bug
>            Reporter: Maksim Logvinenko
>
> After migration from yarn.container.* properties to 
> cluster-manager.container.* properties we have to use either of them and 
> ClusterManagerConfig provides backward compatibility for these properties. 
> But in YarnClusterResourceManager only old properties are used (from 
> YarnConfig), hence if job config migrated to new cluster-manager.* properties 
> names then check will be evaluated against default values, not against actual 
> values.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to