[ 
https://issues.apache.org/jira/browse/SAMZA-1026?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15985725#comment-15985725
 ] 

ASF GitHub Bot commented on SAMZA-1026:
---------------------------------------

GitHub user prateekm opened a pull request:

    https://github.com/apache/samza/pull/144

    SAMZA-1026: HDFS System Producer should not have Kafka dependency

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/prateekm/samza hdfs-kafka-dependency

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/samza/pull/144.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #144
    
----
commit f247a6596cf275f2b80b06ccf61c2fd98596a33c
Author: Prateek Maheshwari <[email protected]>
Date:   2017-04-26T23:16:06Z

    SAMZA-1026: HDFS System Producer should not have Kafka dependency

----


> HDFS System Producer should not have Kafka dependency
> -----------------------------------------------------
>
>                 Key: SAMZA-1026
>                 URL: https://issues.apache.org/jira/browse/SAMZA-1026
>             Project: Samza
>          Issue Type: Sub-task
>            Reporter: Hai
>            Assignee: Prateek Maheshwari
>            Priority: Minor
>             Fix For: 0.13.0
>
>
> Currently HDFSSystemFactory has seemly unnecessary dependency on Kafka:
>   def getProducer(systemName: String, config: Config, registry: 
> MetricsRegistry) = {
>     val clientId = KafkaUtil.getClientId("samza-producer", config)
>     val metrics = new HdfsSystemProducerMetrics(systemName, registry)
>     new HdfsSystemProducer(systemName, clientId, config, metrics)
>   }
> Should try to get rid of the dependency



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to