[
https://issues.apache.org/jira/browse/SAMZA-1250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15991283#comment-15991283
]
ASF GitHub Bot commented on SAMZA-1250:
---------------------------------------
GitHub user jmakes opened a pull request:
https://github.com/apache/samza/pull/152
SAMZA-1250: JobRunner.kill doesn't terminate cleanly with YarnJob.
1. The ClientHelper now checks inactive application IDs so it can get
status for terminated jobs in addition to running jobs
2. JobRunner.kill() waits for any finish, not just successful finish.
3. A killed job is now considered successful.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jmakes/samza samza-1250
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/samza/pull/152.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #152
----
commit d2d924ae2410562830b0d21a9077165f9cf51d12
Author: Jacob Maes <[email protected]>
Date: 2017-04-26T19:32:18Z
SAMZA-1214: Allow users to set a default replication.factor for
intermediate topics
commit 80cd86f428c0df4be07300f0882679baf752423a
Author: Jacob Maes <[email protected]>
Date: 2017-04-26T19:37:04Z
Merge remote-tracking branch 'upstream/master'
commit 7a142c0f479917a890cca53c9a65bb1d38f65f09
Author: Jacob Maes <[email protected]>
Date: 2017-05-01T16:58:51Z
Merge remote-tracking branch 'upstream/master'
commit 40c43543c904cc3d189b18c7a39339dc6b3005c4
Author: Jacob Maes <[email protected]>
Date: 2017-05-01T18:41:52Z
SAMZA-1250: JobRunner.kill doesn't terminate cleanly with YarnJob.
----
> JobRunner.kill doesn't terminate cleanly with YarnJob.
> ------------------------------------------------------
>
> Key: SAMZA-1250
> URL: https://issues.apache.org/jira/browse/SAMZA-1250
> Project: Samza
> Issue Type: Bug
> Reporter: Jake Maes
> Assignee: Jake Maes
> Fix For: 0.13.0
>
>
> I discovered this while working on the wikipedia tutorial with the Fluent
> API.
> Running run-app.sh with --operation=kill will kill the job but doesn't appear
> to do so cleanly. There are a few reasons.
> 1. The client can't get the status for finished jobs because it only looks at
> the active (RUNNING) application IDs
> 2. JobRunner.kill() waits for a successful finish. It should wait for any
> finish
> 3. A killed job is considered an unsuccessful finish. It should be considered
> successful.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
